diff options
| author | Pieter Wuille <pieter@wuille.net> | 2021-12-06 15:45:38 -0500 |
|---|---|---|
| committer | Pieter Wuille <pieter@wuille.net> | 2021-12-06 16:18:14 -0500 |
| commit | 31ba1af74a0aaec690a01ea061264a6d5039d885 (patch) | |
| tree | 9c2d76a9fd160cece7095a8beddb35af586318e5 /src/signet.cpp | |
| parent | 786ffb3ae488061e13c02ad3fb34a5d2fc785b3d (diff) | |
Remove unused (and broken) functionality in SpanReader
This removes the ability to set an offset in the SpanReader constructor,
as the current code is broken. All call sites use pos=0, so it is actually
unused. If future call sites need it, SpanReader{a, b, c, d} is equivalent
to SpanReader{a, b, c.subspan(d)}.
It also removes the ability to deserialize from SpanReader directly from
the constructor. This too is unused, and can be more idiomatically
simulated using (SpanReader{a, b, c} >> x >> y >> z) instead of
SpanReader{a, b, c, x, y, z}.
Diffstat (limited to 'src/signet.cpp')
| -rw-r--r-- | src/signet.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/signet.cpp b/src/signet.cpp index 5cecb8decc..6366851790 100644 --- a/src/signet.cpp +++ b/src/signet.cpp @@ -98,7 +98,7 @@ std::optional<SignetTxs> SignetTxs::Create(const CBlock& block, const CScript& c // no signet solution -- allow this to support OP_TRUE as trivial block challenge } else { try { - SpanReader v{SER_NETWORK, INIT_PROTO_VERSION, signet_solution, 0}; + SpanReader v{SER_NETWORK, INIT_PROTO_VERSION, signet_solution}; v >> tx_spending.vin[0].scriptSig; v >> tx_spending.vin[0].scriptWitness.stack; if (!v.empty()) return std::nullopt; // extraneous data encountered |