diff options
| author | Pieter Wuille <pieter.wuille@gmail.com> | 2017-07-07 15:48:13 -0700 |
|---|---|---|
| committer | Pieter Wuille <pieter.wuille@gmail.com> | 2020-01-02 11:05:27 -0800 |
| commit | ca33451535dc29f64d37c49af8b22142d7716d0d (patch) | |
| tree | a9a7595ae18527643bdd5a434cb8ce3d6ebc66cf /src/serialize.h | |
| parent | 3f8dbcd655479ce2e564a8b17139aca19888ca79 (diff) | |
| download | bitcoin-ca33451535dc29f64d37c49af8b22142d7716d0d.tar.xz | |
Introduce new serialization macros without casts
This new approach uses a static method which takes the object as
a argument. This has the advantage that its constness can be a
template parameter, allowing a single implementation that sees the
object as const for serialization and non-const for deserialization,
without casts.
More boilerplate is included in the new macro as well.
Diffstat (limited to 'src/serialize.h')
| -rw-r--r-- | src/serialize.h | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/src/serialize.h b/src/serialize.h index c84a1567f1..c9e994f844 100644 --- a/src/serialize.h +++ b/src/serialize.h @@ -199,6 +199,30 @@ template<typename X> const X& ReadWriteAsHelper(const X& x) { return x; } SerializationOp(s, CSerActionUnserialize()); \ } +/** + * Implement the Serialize and Unserialize methods by delegating to a single templated + * static method that takes the to-be-(de)serialized object as a parameter. This approach + * has the advantage that the constness of the object becomes a template parameter, and + * thus allows a single implementation that sees the object as const for serializing + * and non-const for deserializing, without casts. + */ +#define SERIALIZE_METHODS(cls, obj) \ + template<typename Stream> \ + void Serialize(Stream& s) const \ + { \ + static_assert(std::is_same<const cls&, decltype(*this)>::value, "Serialize type mismatch"); \ + SerializationOps(*this, s, CSerActionSerialize()); \ + } \ + template<typename Stream> \ + void Unserialize(Stream& s) \ + { \ + static_assert(std::is_same<cls&, decltype(*this)>::value, "Unserialize type mismatch"); \ + SerializationOps(*this, s, CSerActionUnserialize()); \ + } \ + template<typename Stream, typename Type, typename Operation> \ + static inline void SerializationOps(Type& obj, Stream& s, Operation ser_action) \ + + #ifndef CHAR_EQUALS_INT8 template<typename Stream> inline void Serialize(Stream& s, char a ) { ser_writedata8(s, a); } // TODO Get rid of bare char #endif |