diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-09-03 13:22:00 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2020-09-03 13:28:30 +0200 |
| commit | 620ac8c47539b5131e902df272fcc8b2d5a7c54a (patch) | |
| tree | 06803b5b5786b9dc47b3c962ae1ad47727168b67 /src/script/script_error.cpp | |
| parent | 68f0ab26bca825edf7e48a69176c38b04e3158d0 (diff) | |
| parent | eb1c5d090f4ef844dabc1e8bf3864c1afe1c791c (diff) | |
Merge #19724: [net] Cleanup connection types- followups
eb1c5d090f4ef844dabc1e8bf3864c1afe1c791c [doc] Follow developer notes, add comment about missing default. (Amiti Uttarwar)
d5a57cef62ee9e9d30f7e3b80e178149ceeef67c [doc] Describe connection types in more depth. (Amiti Uttarwar)
4829b6fcc6489b445f80689af6c2a1a919f176b1 [refactor] Simplify connection type logic in ThreadOpenConnections (Amiti Uttarwar)
1e563aed785565af6b7aed7f7399c52205d8f19c [refactor] Simplify check for block-relay-only connection. (Amiti Uttarwar)
da3a0be61b025224231206cb4656e420453bfdeb [test] Add explicit tests that connection types get set correctly (Amiti Uttarwar)
1d74fc7df621b31d1b8adc9d7f53e7478d6e40b5 [trivial] Small style updates (Amiti Uttarwar)
ff6b9081add3a40d53b1cc1352b57eeb46e41d45 [doc] Explain address handling logic in process messages (Amiti Uttarwar)
dff16b184b1428a068d144e5e4dde7595b4729c0 [refactor] Restructure logic to check for addr relay. (Amiti Uttarwar)
a6ab1e81f964df131cfa0e11e07bedb3283b823f [net] Remove unnecessary default args on OpenNetworkConnection (Amiti Uttarwar)
8d6ff46f55f373e344278ab3f1ac27b1dba36623 scripted-diff: Rename `OUTBOUND` ConnectionType to `OUTBOUND_FULL_RELAY` (Amiti Uttarwar)
Pull request description:
This PR addresses outstanding review comments from #19316. It further simplifies `net.cpp` complexity and adds documentation about design goals about different connection types.
ACKs for top commit:
naumenkogs:
ACK eb1c5d090f4ef844dabc1e8bf3864c1afe1c791c
laanwj:
Code review ACK eb1c5d090f4ef844dabc1e8bf3864c1afe1c791c
Tree-SHA512: 2fe14e428404c95661e5518c8c90db07ab5b9ebb1bac921b3bdf82b181f444fae379f8fc0a2b619e6b4693f01c55bd246fbd8c8eedadd96849a30de3161afee5
Diffstat (limited to 'src/script/script_error.cpp')
0 files changed, 0 insertions, 0 deletions