diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-05-31 10:39:09 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-05-31 10:40:11 +0200 |
| commit | 36fc8052f62b87b11b0366fefee5f38dc886aefd (patch) | |
| tree | efc43211c385bb55221a12830ff087ae33d4ee5d /src/scheduler.h | |
| parent | 472fe8a2ce9f08f0311e4a04eef996eba19ff985 (diff) | |
| parent | 6b8b63af1461dc11ffd813401e2c36fa44656715 (diff) | |
| download | bitcoin-36fc8052f62b87b11b0366fefee5f38dc886aefd.tar.xz | |
Merge #13309: Directly operate with CMutableTransaction in SignSignature
6b8b63af1461dc11ffd813401e2c36fa44656715 Generic TransactionSignatureCreator works with both CTransaction and CMutableTransaction (Martin Ankerl)
Pull request description:
Refactored `TransactionSignatureCreator` into a templated `GenericTransactionSignatureCreator` that works with both `CMutableTransaction` and `CTransaction`.
The advantage is that now in `SignSignature`, the `MutableTransactionSignatureCreator` can now operate directly with the `CMutableTransaction` without the need to copy the data into a `CTransaction`.
Running all unit tests brings a very noticable speedup on my machine:
48.4 sec before this change
36.4 sec with this change
--------
12.0 seconds saved
running only `--run_test=transaction_tests/test_big_witness_transaction`:
16.7 sec before this change
5.9 sec with this change
--------
10.8 seconds saved
This relates to my first attempt with the const_cast hack #13202, and to the slow unit test issue #10026.
Also see #13050 which modifies the tests but not the production code (like this PR) to get a speedup.
Tree-SHA512: 2cff0e9699f484f26120a40e431a24c8bc8f9e780fd89cb0ecf20c5be3eab6c43f9c359cde244abd9f3620d06c7c354e3b9dd3da41fa2ca1ac1e09386fea25fb
Diffstat (limited to 'src/scheduler.h')
0 files changed, 0 insertions, 0 deletions