diff options
| author | Gregory Maxwell <greg@xiph.org> | 2015-02-08 00:59:58 +0000 |
|---|---|---|
| committer | Gregory Maxwell <greg@xiph.org> | 2015-02-08 19:58:59 +0000 |
| commit | 28d4cff0ed2d4438da4bbf2d4ca0465715603af5 (patch) | |
| tree | 052974da2c9aba3e088f4e714f66a0962cda6710 /src/rpcserver.cpp | |
| parent | fb6140b54bad51e3b063dfb005bfde13aca64eb4 (diff) | |
| download | bitcoin-28d4cff0ed2d4438da4bbf2d4ca0465715603af5.tar.xz | |
Sanitize command strings before logging them.
Normally bitcoin core does not display any network originated strings without
sanitizing or hex encoding. This wasn't done for strcommand in many places.
This could be used to play havoc with a terminal displaying the logs,
especially with printtoconsole in use.
Thanks to Evil-Knievel for reporting this issue.
Diffstat (limited to 'src/rpcserver.cpp')
| -rw-r--r-- | src/rpcserver.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/rpcserver.cpp b/src/rpcserver.cpp index 823b1fcf24..20e9252d7e 100644 --- a/src/rpcserver.cpp +++ b/src/rpcserver.cpp @@ -849,7 +849,7 @@ void JSONRequest::parse(const Value& valRequest) throw JSONRPCError(RPC_INVALID_REQUEST, "Method must be a string"); strMethod = valMethod.get_str(); if (strMethod != "getblocktemplate") - LogPrint("rpc", "ThreadRPCServer method=%s\n", strMethod); + LogPrint("rpc", "ThreadRPCServer method=%s\n", SanitizeString(strMethod)); // Parse params Value valParams = find_value(request, "params"); |