diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2014-01-27 10:31:22 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2014-01-29 14:46:06 +0100 |
| commit | 4412c5a759affdcdb8c9c81b64465979aaba147a (patch) | |
| tree | a2b67764a4f7cbdddc5eb6412a6633a3148b6b07 /src/rpcnet.cpp | |
| parent | e16ee005ec7ed97c41ef1ebb6270b2c8dd6fb178 (diff) | |
| download | bitcoin-4412c5a759affdcdb8c9c81b64465979aaba147a.tar.xz | |
Fix `getaddednodeinfo` RPC call with dns=false
The getaddednodeinfo RPC call, when invoked with the dns flag set to
false, returns a malformed JSON object with duplicate keys.
Change this to return an array of objects with one key as
shown in the help message.
Fixes #3581.
Diffstat (limited to 'src/rpcnet.cpp')
| -rw-r--r-- | src/rpcnet.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/src/rpcnet.cpp b/src/rpcnet.cpp index 06ae7070c3..a3b37aa9e5 100644 --- a/src/rpcnet.cpp +++ b/src/rpcnet.cpp @@ -255,16 +255,18 @@ Value getaddednodeinfo(const Array& params, bool fHelp) throw JSONRPCError(RPC_CLIENT_NODE_NOT_ADDED, "Error: Node has not been added."); } + Array ret; if (!fDns) { - Object ret; BOOST_FOREACH(string& strAddNode, laddedNodes) - ret.push_back(Pair("addednode", strAddNode)); + { + Object obj; + obj.push_back(Pair("addednode", strAddNode)); + ret.push_back(obj); + } return ret; } - Array ret; - list<pair<string, vector<CService> > > laddedAddreses(0); BOOST_FOREACH(string& strAddNode, laddedNodes) { |