aboutsummaryrefslogtreecommitdiff
path: root/src/rpc
diff options
context:
space:
mode:
authorfurszy <matiasfurszyfer@protonmail.com>2023-09-19 08:09:23 -0300
committerfurszy <matiasfurszyfer@protonmail.com>2023-09-26 20:17:02 -0300
commitb3db8c9d5ccfe5c31341169fa7ac044427122921 (patch)
tree5092edd4c1cb7349c7c90932cc19699080fb2875 /src/rpc
parent1d4846a8443be901b8a5deb0e357481af22838d0 (diff)
rpc: bumpfee, improve doc for 'reduce_output' arg
The current argument name and description are dangerous as it don't describe the case where the user selects the recipient output as the change address. This one could end up been increased by the inputs minus outputs remainder. Which, when bumpfee adds new inputs to the transaction, leads the process to send more coins to the recipient. Which is not what the user would expect from a 'reduce_output' param naming. Co-authored-by: Murch <murch@murch.one>
Diffstat (limited to 'src/rpc')
-rw-r--r--src/rpc/client.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp
index 0ee3f27761..1e5e231cef 100644
--- a/src/rpc/client.cpp
+++ b/src/rpc/client.cpp
@@ -263,13 +263,13 @@ static const CRPCConvertParam vRPCConvertParams[] =
{ "bumpfee", 1, "fee_rate"},
{ "bumpfee", 1, "replaceable"},
{ "bumpfee", 1, "outputs"},
- { "bumpfee", 1, "reduce_output"},
+ { "bumpfee", 1, "original_change_index"},
{ "psbtbumpfee", 1, "options" },
{ "psbtbumpfee", 1, "conf_target"},
{ "psbtbumpfee", 1, "fee_rate"},
{ "psbtbumpfee", 1, "replaceable"},
{ "psbtbumpfee", 1, "outputs"},
- { "psbtbumpfee", 1, "reduce_output"},
+ { "psbtbumpfee", 1, "original_change_index"},
{ "logging", 0, "include" },
{ "logging", 1, "exclude" },
{ "disconnectnode", 1, "nodeid" },