diff options
| author | Andrew Chow <github@achow101.com> | 2023-02-03 17:32:35 -0500 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-02-03 17:32:46 -0500 |
| commit | d71b0e78eb0f24e8b147657c8561d74e441c2503 (patch) | |
| tree | f67b1682f92ad2af8e28f4b4a30ec0dbbb5b4bdd /src/rpc | |
| parent | e2ae5c349cd9c0e1db090ca3df3160f26d5c105d (diff) | |
| parent | fb1c6c14c11ccd4833c1a24f77c507f098d369ad (diff) | |
| download | bitcoin-d71b0e78eb0f24e8b147657c8561d74e441c2503.tar.xz | |
Merge bitcoin/bitcoin#25966: test: Remove redundant test
fb1c6c14c11ccd4833c1a24f77c507f098d369ad test: Remove redundant test (yancy)
Pull request description:
I can't think of any reason to keep this test case around labeled [fix me](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L242). The test was originally added [here](https://github.com/bitcoin/bitcoin/commit/4566ab75f277612425337bf7786c1d3a410d894a) however there was never an assertion about the coins that should be selected, only that a solution is found (which is a redundant solution to the test [above](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L222)). The comment was later added here to [fix](https://github.com/bitcoin/bitcoin/commit/384273260a6ccbcf79dade0830011f528e5a1581) it, however it's unclear what exactly it's testing. A test was later added [here](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L366) where if the [long term fee](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L357) is less than the current [fee](https://github.com/bitcoin/bitcoin/blob/master/src/wallet/test/coinselector_tests.cpp#L356), then select fewer UTXOs, which may have been the original intent.
ACKs for top commit:
S3RK:
ACK fb1c6c14c11ccd4833c1a24f77c507f098d369ad
Zero-1729:
Concept ACK fb1c6c14c11ccd4833c1a24f77c507f098d369ad
achow101:
ACK fb1c6c14c11ccd4833c1a24f77c507f098d369ad
Tree-SHA512: bce2cdae669c144ffaa130237a1643e3b6728e13d603cebf5d9493c4c7c68b3635868e4d93d210783c2ded2a871f185ca09a2053168c05b26a1e056ff6edf68f
Diffstat (limited to 'src/rpc')
0 files changed, 0 insertions, 0 deletions