diff options
| author | MacroFake <falke.marco@gmail.com> | 2022-07-19 09:15:55 +0200 |
|---|---|---|
| committer | MacroFake <falke.marco@gmail.com> | 2022-07-19 09:16:01 +0200 |
| commit | 47c86a023d9e3d077a22d38dcd2d6bb79a2da18e (patch) | |
| tree | 14b42a54d62c7944fe58b3d577e4884faba2943f /src/rpc | |
| parent | 2bdce7f7adbdec018405cb993d16cecb5fb429f6 (diff) | |
| parent | a02f3f19f52e628248f81acc2410e67f3d49baf5 (diff) | |
Merge bitcoin/bitcoin#25466: ci: add unused-using-decls to clang-tidy
a02f3f19f52e628248f81acc2410e67f3d49baf5 tidy: use misc-unused-using-decls (fanquake)
d6787bc19b1032d3f46a60625105f30199c41b00 refactor: remove unused using directives (fanquake)
3617634324d647956c621db407db6d82a91b91ec validation: remove unused using directives (eugene)
Pull request description:
Adds https://clang.llvm.org/extra/clang-tidy/checks/misc/unused-using-decls.html to our clang-tidy.
PR'd after the discussion in #25433 (which it includes).
ACKs for top commit:
jamesob:
Github ACK https://github.com/bitcoin/bitcoin/pull/25466/commits/a02f3f19f52e628248f81acc2410e67f3d49baf5
Tree-SHA512: 2bb937c1cc90006e69054458d845fb54f287567f4309c773a3fc859f260558c32ff51fc1c2ce9b43207426f3547e7ce226c87186103d741d5efcca19cd355253
Diffstat (limited to 'src/rpc')
| -rw-r--r-- | src/rpc/mempool.cpp | 1 | ||||
| -rw-r--r-- | src/rpc/output_script.cpp | 5 | ||||
| -rw-r--r-- | src/rpc/rawtransaction.cpp | 2 |
3 files changed, 0 insertions, 8 deletions
diff --git a/src/rpc/mempool.cpp b/src/rpc/mempool.cpp index 3b53ec82e4..d59ff3f75c 100644 --- a/src/rpc/mempool.cpp +++ b/src/rpc/mempool.cpp @@ -25,7 +25,6 @@ using kernel::DumpMempool; using node::DEFAULT_MAX_RAW_TX_FEE_RATE; using node::MempoolPath; -using node::ShouldPersistMempool; using node::NodeContext; static RPCHelpMan sendrawtransaction() diff --git a/src/rpc/output_script.cpp b/src/rpc/output_script.cpp index f4bb76f50f..744f809814 100644 --- a/src/rpc/output_script.cpp +++ b/src/rpc/output_script.cpp @@ -26,11 +26,6 @@ #include <tuple> #include <vector> -namespace node { -struct NodeContext; -} -using node::NodeContext; - static RPCHelpMan validateaddress() { return RPCHelpMan{ diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp index 43e0e6bc2d..16105a85d5 100644 --- a/src/rpc/rawtransaction.cpp +++ b/src/rpc/rawtransaction.cpp @@ -46,12 +46,10 @@ #include <univalue.h> using node::AnalyzePSBT; -using node::BroadcastTransaction; using node::FindCoins; using node::GetTransaction; using node::NodeContext; using node::PSBTAnalysis; -using node::ReadBlockFromDisk; static void TxToJSON(const CTransaction& tx, const uint256 hashBlock, UniValue& entry, CChainState& active_chainstate) { |