diff options
| author | Andrew Chow <github@achow101.com> | 2023-09-27 16:35:30 -0400 |
|---|---|---|
| committer | Andrew Chow <github@achow101.com> | 2023-09-27 16:46:27 -0400 |
| commit | 19a7e608f97838a58c2bbc058c6aea1d5ffe675f (patch) | |
| tree | 8105b31c000814489891f0dd2fffea86f52092e5 /src/rpc | |
| parent | c9f288244b8d183e09a917025922b99e3368ef78 (diff) | |
| parent | b3db8c9d5ccfe5c31341169fa7ac044427122921 (diff) | |
Merge bitcoin/bitcoin#28505: rpc: bumpfee, improve doc for 'reduce_output' arg
b3db8c9d5ccfe5c31341169fa7ac044427122921 rpc: bumpfee, improve doc for 'reduce_output' arg (furszy)
Pull request description:
Fixes #28180. Resulted from discussions with S3RK, achow101, and Murch.
The current argument name and description are dangerous as it don't
describe the case where the user selects the recipient output as the
change address. This one could end up been increased by the inputs
minus outputs remainder. Which, when `bumpfee` adds new inputs
to the transaction, leads the process to send more coins to the
recipient. Which is not what the user would expect from a
'reduce_output' param naming.
ACKs for top commit:
S3RK:
ACK b3db8c9d5ccfe5c31341169fa7ac044427122921
achow101:
ACK b3db8c9d5ccfe5c31341169fa7ac044427122921
murchandamus:
ACK b3db8c9d5ccfe5c31341169fa7ac044427122921
Tree-SHA512: 91f607e2f5849041d7c099afdddae11af8bed5b1ac90c9d22921267f272e21b44e107d6968e037f05f958a61fe29e94e5fb44b224fb3606f197f83ec4ba3b1e7
Diffstat (limited to 'src/rpc')
| -rw-r--r-- | src/rpc/client.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/rpc/client.cpp b/src/rpc/client.cpp index 0ee3f27761..1e5e231cef 100644 --- a/src/rpc/client.cpp +++ b/src/rpc/client.cpp @@ -263,13 +263,13 @@ static const CRPCConvertParam vRPCConvertParams[] = { "bumpfee", 1, "fee_rate"}, { "bumpfee", 1, "replaceable"}, { "bumpfee", 1, "outputs"}, - { "bumpfee", 1, "reduce_output"}, + { "bumpfee", 1, "original_change_index"}, { "psbtbumpfee", 1, "options" }, { "psbtbumpfee", 1, "conf_target"}, { "psbtbumpfee", 1, "fee_rate"}, { "psbtbumpfee", 1, "replaceable"}, { "psbtbumpfee", 1, "outputs"}, - { "psbtbumpfee", 1, "reduce_output"}, + { "psbtbumpfee", 1, "original_change_index"}, { "logging", 0, "include" }, { "logging", 1, "exclude" }, { "disconnectnode", 1, "nodeid" }, |