diff options
author | Andrew Chow <achow101-github@achow101.com> | 2019-08-02 19:19:53 -0400 |
---|---|---|
committer | Andrew Chow <achow101-github@achow101.com> | 2019-08-16 19:34:01 -0400 |
commit | 625534d7b1417da926f1ced600855ea818d6e01e (patch) | |
tree | b7ec5d310f4f2e169e57516c0032ff0c98156833 /src/rpc | |
parent | c325f619dd071b5489989f645e42cace8eb23fb4 (diff) |
Give more errors for specific failure conditions
Some failure conditions implicitly fail by failing some other check.
But the error messages are more helpful if they say explicitly what
actually caused the failure, so add those as failure conditions and
errors.
Diffstat (limited to 'src/rpc')
-rw-r--r-- | src/rpc/misc.cpp | 4 | ||||
-rw-r--r-- | src/rpc/util.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/rpc/misc.cpp b/src/rpc/misc.cpp index e48ed8db75..1516007201 100644 --- a/src/rpc/misc.cpp +++ b/src/rpc/misc.cpp @@ -153,7 +153,7 @@ UniValue getdescriptorinfo(const JSONRPCRequest& request) std::string error; auto desc = Parse(request.params[0].get_str(), provider, error); if (!desc) { - throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Invalid descriptor, %s", error)); + throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, error); } UniValue result(UniValue::VOBJ); @@ -203,7 +203,7 @@ UniValue deriveaddresses(const JSONRPCRequest& request) std::string error; auto desc = Parse(desc_str, key_provider, error, /* require_checksum = */ true); if (!desc) { - throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Invalid descriptor, %s", error)); + throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, error); } if (!desc->IsRange() && request.params.size() > 1) { diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp index 52b2b94852..464537a5b0 100644 --- a/src/rpc/util.cpp +++ b/src/rpc/util.cpp @@ -720,7 +720,7 @@ std::vector<CScript> EvalDescriptorStringOrObject(const UniValue& scanobject, Fl std::string error; auto desc = Parse(desc_str, provider, error); if (!desc) { - throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, strprintf("Invalid descriptor '%s', %s", desc_str, error)); + throw JSONRPCError(RPC_INVALID_ADDRESS_OR_KEY, error); } if (!desc->IsRange()) { range.first = 0; |