diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-04-04 16:45:12 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-04-04 16:45:23 -0400 |
| commit | c83442e17412b96f00bc29d30763b28184c95f1e (patch) | |
| tree | ea4d807d295bac57bbf8dc0143669028012ebc2e /src/rpc/server.cpp | |
| parent | daef20fb50c00240ea4a5d653f3a47ee604d25c1 (diff) | |
| parent | fa8548c5d13957f57f9b1e20e03002600962f7f0 (diff) | |
| download | bitcoin-c83442e17412b96f00bc29d30763b28184c95f1e.tar.xz | |
Merge #15654: net: Remove unused unsanitized user agent string CNode::strSubVer
fa8548c5d1 net: Remove unused unsanitized user agent string CNode::strSubVer (MarcoFalke)
Pull request description:
I fail to see a use case for this unsanitized byte array. In fact this can easily be confused with `cleanSubVer` and be displayed to the user (or logged) by a simple typo that is hard to find in review.
Further reading: https://btcinformation.org/en/developer-reference#version
ACKs for commit fa8548:
promag:
utACK fa8548c, good catch.
practicalswift:
utACK fa8548c5d13957f57f9b1e20e03002600962f7f0
sipa:
utACK fa8548c5d13957f57f9b1e20e03002600962f7f0
Tree-SHA512: 3c3ff1504d1583ad099df9a6aa761458a82ec48a58ef7aaa9b5679a5281dd1b59036ba2932ed708488951a565b669a3083ef70be5a58472ff8677b971162ae2f
Diffstat (limited to 'src/rpc/server.cpp')
0 files changed, 0 insertions, 0 deletions