diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-05-29 14:23:37 -0400 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-05-29 14:23:43 -0400 |
commit | cb88de3e3d37842199a17ba3d36838fc69fbe573 (patch) | |
tree | 534ae4b88139086bb78886e2c52ee9995bca538d /src/rpc/server.cpp | |
parent | 8ad5f1c376fe99eeccac2696ac0e18e662323a4d (diff) | |
parent | f871f15c9d760b56a6a3b78b3941d3983d60810c (diff) | |
download | bitcoin-cb88de3e3d37842199a17ba3d36838fc69fbe573.tar.xz |
Merge #18926: test: Pass ArgsManager into getarg_tests
f871f15c9d760b56a6a3b78b3941d3983d60810c scripted-diff: replace gArgs with argsman (glowang)
357f02bf2942f2944a04a1ceaa687f89d5da7d28 Create a local class inherited from BasicTestingSetup with a localized args manager and put it into the getarg_tests namespace (glowang)
Pull request description:
Replaced the global argsManager gArgs with a locally defined one in getarg_tests. This is to avoid confusion in arg settings between the test's ArgsManager and the #18804
ACKs for top commit:
MarcoFalke:
ACK f871f15c9d760b56a6a3b78b3941d3983d60810c
ryanofsky:
Code review ACK f871f15c9d760b56a6a3b78b3941d3983d60810c. Changes look good and thanks for updating. In future would recommend using clang-format-diff and following [coding style](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#coding-style-c) notes, because it's atypical to indent namespace content, or indent protected keywords or put spaces around ::. Also it's fragile to define test setup class in a namespace, but test setup methods outside of the namespace and inside the test fixture instead. Would be simpler to just define the testing setup completely before using it without a namespace like: https://github.com/bitcoin/bitcoin/blob/8ad5f1c376fe99eeccac2696ac0e18e662323a4d/src/test/rpc_tests.cpp#L23 and it would have been a slightly smaller change too.
Tree-SHA512: 016594639396d60667fadec8ea80ef7af634fbb2014c704f02406fe3251c5362757c21f1763d8bdb94ca4a3026ab9dc786a92a9a934efc8cd807655d9deee779
Diffstat (limited to 'src/rpc/server.cpp')
0 files changed, 0 insertions, 0 deletions