diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-09 11:47:55 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2019-07-09 11:48:01 +0200 |
| commit | 8046a3e0befeea641b6309bc0c742b7481e681d9 (patch) | |
| tree | 3b5f07c033ea26fffcc2878def904d4b293efcbb /src/rpc/protocol.h | |
| parent | c799976c86e2d65f129d106724fbefbf665d63d4 (diff) | |
| parent | 64fee489448c62319e77941c30152084695b5a5d (diff) | |
Merge #16348: qt: Assert QMetaObject::invokeMethod result
64fee489448c62319e77941c30152084695b5a5d qt: Assert QMetaObject::invokeMethod result (João Barbosa)
f27bd96b5fdc2921d93c44bbf422bff0e979c4de gui: Fix missing qRegisterMetaType(WalletModel*) (João Barbosa)
Pull request description:
Invalid/wrong dynamic calls aren't verified by the compiler. This PR asserts those dynamic calls. Once we bump Qt to at least 5.10 these can be refactored to use the `invokeMethod` overload that allows connecting to lambdas or member pointers, which are compile checked.
For reference, one of the overloaded versions is https://doc.qt.io/qt-5/qmetaobject.html#invokeMethod-5.
ACKs for top commit:
laanwj:
ACK 64fee489448c62319e77941c30152084695b5a5d
Tree-SHA512: d332e5d7eb2c7be5d3fe90e2e4ff20a67800b9664f6637c122a23647a964f7915703d3f086e2de440f695cfe14de268ff581d0092b7736e911952a4f4d248e25
Diffstat (limited to 'src/rpc/protocol.h')
0 files changed, 0 insertions, 0 deletions