diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-08-22 08:56:23 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2017-08-22 08:56:33 +0200 |
| commit | ea3ac5990d9d810bab83f7d64cf0707d93d18887 (patch) | |
| tree | a5c517b800b43165b2310e13627f5c37489162e3 /src/rpc/blockchain.cpp | |
| parent | 271e40a98984965b666eff4a0e5540fe987236c8 (diff) | |
| parent | 4aa25089b4392a9a17ba5b3a8ea22e893d11d876 (diff) | |
| download | bitcoin-ea3ac5990d9d810bab83f7d64cf0707d93d18887.tar.xz | |
Merge #11026: Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default
4aa2508 Bugfix: Use testnet RequireStandard for -acceptnonstdtxn default (Luke Dashjr)
Pull request description:
Fixes a bug introduced in #8855
`-acceptnonstdtxn` is a valid option only for testnet/regtest (in Core), and the help message reflects that. Currently, however, it is buggy in two ways:
1. It uses mainnet to get the default value, which doesn't make sense since the option is never available for mainnet, and the only time the option is available, is when the default is the opposite.
2. It uses the value of "require standard" directly as the default for "accept non-standard transactions", but these concepts are opposites: a negation must be performed to transform one to the other.
Note the combination of these bugs results in the correct boolean output, but the logic to get there is completely wrong.
Tree-SHA512: 06ce513f59ba31f7ab4b6422a08a17bb37a5652dea4c38a4bbefedd5e2752d17bfccc32a4b0508068fa4783e316bff00a821ef18a24b1a2bb02859995d188fdc
Diffstat (limited to 'src/rpc/blockchain.cpp')
0 files changed, 0 insertions, 0 deletions