diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-03-13 10:20:10 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-03-13 10:20:15 +0100 |
| commit | 2860a91df0d7a284644d20db92748e7954b67a25 (patch) | |
| tree | b142d7138b12b3ae23b7adf450f320534c072fba /src/random.h | |
| parent | f94784f5bcfd0adf5d20f9631cde454348b4ff71 (diff) | |
| parent | 5ce3057c8e8f192921fd5e4bdb95bb15e3f7dbad (diff) | |
Merge bitcoin/bitcoin#24527: test: set segwit height back to 0 on regtest
5ce3057c8e8f192921fd5e4bdb95bb15e3f7dbad test: set segwit height back to 0 on regtest (Martin Zumsande)
Pull request description:
The change of `consensus.SegwitHeight` from 0 to 1 for regtest in #22818 had the effect that if I create a regtest enviroment with current master (or 23.x), and then try to load this chain with an older version (22.x), I get an InitError
`Witness data for blocks after height 0 requires validation. Please restart with -reindex`
and have to reindex because `BLOCK_OPT_WITNESS` is no longer set for the Genesis block and `NeedsRedownload()` in validation returns `true` with an older version.
That might be a bit annoying for tests that use a shared regtest dir with different versions.
If people think this is enough of an issue to be worth fixing, I think it should also make it into 23.x
ACKs for top commit:
theStack:
Concept and code-review ACK 5ce3057c8e8f192921fd5e4bdb95bb15e3f7dbad
Tree-SHA512: b0e89ff7fc953bc0ae929d2da44cde7149321d987fb4763934f6c9635d00d807129a50b459cc5e69e86bb1819e4b063b969486e8016a1cb8db8f905fa315653d
Diffstat (limited to 'src/random.h')
0 files changed, 0 insertions, 0 deletions