diff options
author | Cory Fields <cory-nospam-@coryfields.com> | 2017-10-04 18:25:34 -0400 |
---|---|---|
committer | Carl Dong <accounts@carldong.me> | 2019-01-16 11:04:05 -0500 |
commit | 7cc2b9f6786f9bc33853220551eed33ca6b7b7b2 (patch) | |
tree | 93ed4cf7b37c8994fefc4fb31eac75acea9f7329 /src/qt | |
parent | f71c2ea6620a262dd97ba01bdd3dfb3e619cb8cb (diff) | |
download | bitcoin-7cc2b9f6786f9bc33853220551eed33ca6b7b7b2.tar.xz |
net: Break disconnecting out of Ban()
These are separate events which need to be carried out by separate subsystems.
This also cleans up some whitespace and tabs in qt to avoid getting flagged by
the linter.
Current behavior is preserved.
Diffstat (limited to 'src/qt')
-rw-r--r-- | src/qt/rpcconsole.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp index 2949e43915..2989e1e9e5 100644 --- a/src/qt/rpcconsole.cpp +++ b/src/qt/rpcconsole.cpp @@ -1216,16 +1216,16 @@ void RPCConsole::banSelectedNode(int bantime) // Get currently selected peer address NodeId id = nodes.at(i).data().toLongLong(); - // Get currently selected peer address - int detailNodeRow = clientModel->getPeerTableModel()->getRowByNodeId(id); - if(detailNodeRow < 0) - return; - - // Find possible nodes, ban it and clear the selected node - const CNodeCombinedStats *stats = clientModel->getPeerTableModel()->getNodeStats(detailNodeRow); - if(stats) { + // Get currently selected peer address + int detailNodeRow = clientModel->getPeerTableModel()->getRowByNodeId(id); + if (detailNodeRow < 0) return; + + // Find possible nodes, ban it and clear the selected node + const CNodeCombinedStats *stats = clientModel->getPeerTableModel()->getNodeStats(detailNodeRow); + if (stats) { m_node.ban(stats->nodeStats.addr, BanReasonManuallyAdded, bantime); - } + m_node.disconnect(stats->nodeStats.addr); + } } clearSelectedNode(); clientModel->getBanTableModel()->refresh(); |