diff options
| author | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2022-12-16 09:15:31 +0100 |
|---|---|---|
| committer | MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz> | 2022-12-16 09:15:37 +0100 |
| commit | 5055d07edf4625d23c36d548d3598d7b578c05fb (patch) | |
| tree | d1959e5962d27b56577587a6dc1d3dc9d456733c /src/qt | |
| parent | 03708dac0ac69b256ce8c51a5443c443430abeeb (diff) | |
| parent | c39619eeb4e615eb991143edb99e031dd562d0f6 (diff) | |
Merge bitcoin-core/gui#685: clang-tidy: Fix `readability-redundant-string-init` in headers
c39619eeb4e615eb991143edb99e031dd562d0f6 clang-tidy: Fix `readability-redundant-string-init` in headers (Hennadii Stepanov)
Pull request description:
Split from bitcoin/bitcoin#26705 as was requested in https://github.com/bitcoin/bitcoin/pull/26705#issuecomment-1353293405.
To test this PR, consider applying a diff as follows:
```diff
--- a/src/.clang-tidy
+++ b/src/.clang-tidy
@@ -12,17 +12,9 @@ readability-redundant-declaration,
readability-redundant-string-init,
'
WarningsAsErrors: '
-bugprone-argument-comment,
-bugprone-use-after-move,
-misc-unused-using-decls,
-modernize-use-default-member-init,
-modernize-use-nullptr,
-performance-for-range-copy,
-performance-move-const-arg,
-performance-unnecessary-copy-initialization,
-readability-redundant-declaration,
readability-redundant-string-init,
'
CheckOptions:
- key: performance-move-const-arg.CheckTriviallyCopyableMove
value: false
+HeaderFilterRegex: '.'
```
ACKs for top commit:
MarcoFalke:
review ACK c39619eeb4e615eb991143edb99e031dd562d0f6
Tree-SHA512: d7b61be17737f68b8bb40b084cf03f89eae86f4951da2aa000fde0c5245491a01dbb83e5d6e870c6bab4de2dbb5c0eb0dd6613da71592b3a27cf2000a45eaeeb
Diffstat (limited to 'src/qt')
| -rw-r--r-- | src/qt/transactionrecord.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/qt/transactionrecord.h b/src/qt/transactionrecord.h index d8748d7dc9..fe9c85279e 100644 --- a/src/qt/transactionrecord.h +++ b/src/qt/transactionrecord.h @@ -76,12 +76,12 @@ public: static const int RecommendedNumConfirmations = 6; TransactionRecord(): - hash(), time(0), type(Other), address(""), debit(0), credit(0), idx(0) + hash(), time(0), type(Other), debit(0), credit(0), idx(0) { } TransactionRecord(uint256 _hash, qint64 _time): - hash(_hash), time(_time), type(Other), address(""), debit(0), + hash(_hash), time(_time), type(Other), debit(0), credit(0), idx(0) { } |