diff options
| author | Jonas Schnelli <dev@jonasschnelli.ch> | 2018-01-03 21:58:37 -1000 |
|---|---|---|
| committer | Jonas Schnelli <dev@jonasschnelli.ch> | 2018-01-03 21:58:46 -1000 |
| commit | a1136f0cb449122e5591e29a7f71c1ec7dc0937b (patch) | |
| tree | 2432fefa541d3e217d51f76072ea5f68a5241f31 /src/qt | |
| parent | c991b304dee368f506cfee27ddaa333f1f82c518 (diff) | |
| parent | 6dda059bde0798f54626108beab29d9d3834769c (diff) | |
| download | bitcoin-a1136f0cb449122e5591e29a7f71c1ec7dc0937b.tar.xz | |
Merge #12074: [qt] Optimizes boolean expression model && model->haveWatchOnly()
6dda059bd [qt] Simplifies boolean expression model && model->haveWatchOnly() (251)
Pull request description:
This PR optimizes the boolean expression `model && model->haveWatchOnly()` to `model->haveWatchOnly()`.
The boolean expression can be optimized because the method `TransactionView::exportClicked` already guards against a potential dereferenced null pointer by returning early if `model` is null.
https://github.com/bitcoin/bitcoin/blob/63a4dc10876bfc61c2e87d35dcf17da2f0f8c316/src/qt/transactionview.cpp#L351-L353
Tree-SHA512: 8bdd0d05bf879745fa39d3ca7524471720ae08ceee9427d5a08776e7b56d18542ae87a6991cd6779e232305f504fdfc77223702b72ecbe231f5f5e98453456dd
Diffstat (limited to 'src/qt')
| -rw-r--r-- | src/qt/transactionview.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qt/transactionview.cpp b/src/qt/transactionview.cpp index 868934288b..fa43ab750a 100644 --- a/src/qt/transactionview.cpp +++ b/src/qt/transactionview.cpp @@ -365,7 +365,7 @@ void TransactionView::exportClicked() // name, column, role writer.setModel(transactionProxyModel); writer.addColumn(tr("Confirmed"), 0, TransactionTableModel::ConfirmedRole); - if (model && model->haveWatchOnly()) + if (model->haveWatchOnly()) writer.addColumn(tr("Watch-only"), TransactionTableModel::Watchonly); writer.addColumn(tr("Date"), 0, TransactionTableModel::DateRole); writer.addColumn(tr("Type"), TransactionTableModel::Type, Qt::EditRole); |