diff options
| author | Mark Friedenbach <mark@blockstream.io> | 2014-10-16 16:16:29 -0700 |
|---|---|---|
| committer | Mark Friedenbach <mark@blockstream.io> | 2014-10-17 00:33:31 -0700 |
| commit | d4746d56c0c45b8721da36bc19b2bdaba5d7d094 (patch) | |
| tree | 01304911064e6f0ccce518ab2d7456b89681d0c4 /src/qt | |
| parent | e8f6d54f1f58d9a5998e37367b84b427e51e1ad7 (diff) | |
Add a SECURE style flag for ThreadSafeMessageBox, which indicates that the message contains sensitive information. This keeps the message from being output to the debug log by bitcoind. Fixes a possible security risk when starting bitcoind in server mode without the 'rpcpassword' option configured, resulting in the "suggested" password being output to the debug log.
Diffstat (limited to 'src/qt')
| -rw-r--r-- | src/qt/bitcoingui.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp index 8a945606dc..9d6d07a56b 100644 --- a/src/qt/bitcoingui.cpp +++ b/src/qt/bitcoingui.cpp @@ -992,6 +992,9 @@ void BitcoinGUI::showProgress(const QString &title, int nProgress) static bool ThreadSafeMessageBox(BitcoinGUI *gui, const std::string& message, const std::string& caption, unsigned int style) { bool modal = (style & CClientUIInterface::MODAL); + // The SECURE flag has no effect in the Qt GUI. + // bool secure = (style & CClientUIInterface::SECURE); + style &= ~CClientUIInterface::SECURE; bool ret = false; // In case of modal message, use blocking connection to wait for user to click a button QMetaObject::invokeMethod(gui, "message", |