diff options
| author | fanquake <fanquake@gmail.com> | 2023-09-21 16:32:34 +0000 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-09-21 16:32:59 +0000 |
| commit | b66f6dcb26906ca8187c7e54735e21168b8101c7 (patch) | |
| tree | a627ae9927b77dad6a09edf4e2941b712168b625 /src/qt | |
| parent | f29091410d2de8279c727bda5ed21595d4e8bbdc (diff) | |
| parent | 43cd8029fa39e0bd4bf6fb896952952bcae16160 (diff) | |
Merge bitcoin/bitcoin#28513: ci: Install Homebrew's `pkg-config` package
43cd8029fa39e0bd4bf6fb896952952bcae16160 ci: Install Homebrew's `pkg-config` package (Hennadii Stepanov)
Pull request description:
Some versions of macOS images lack the `pkg-config` package.
For example, https://github.com/bitcoin/bitcoin/actions/runs/6248032071/job/16961797066:
```
Runner Image
Image: macos-13
Version: 20230417.1
```
```
+ ./autogen.sh
configure.ac:16: error: PKG_PROG_PKG_CONFIG macro not found. Please install pkg-config and re-run autogen.sh
```
This PR makes Homebrew install the `pkg-config` package explicitly.
Also please refer to [macOS Build Guide](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md).
ACKs for top commit:
kevkevinpal:
ACK [43cd802](https://github.com/bitcoin/bitcoin/pull/28513/commits/43cd8029fa39e0bd4bf6fb896952952bcae16160)
MarcoFalke:
lgtm ACK 43cd8029fa39e0bd4bf6fb896952952bcae16160
RandyMcMillan:
ACK 43cd802
Tree-SHA512: 2b934b22e5f6748634089e0525b92219484e37b2afc11e9fd4c53faf112b33ca1c8deb5b4aa36939bf5c4807e7599d4aabae6335317ecc5d4a4d562bbd7dbdf2
Diffstat (limited to 'src/qt')
0 files changed, 0 insertions, 0 deletions