diff options
| author | fanquake <fanquake@gmail.com> | 2019-06-23 18:39:53 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-06-23 18:57:27 +0800 |
| commit | c1bab5052a2b3e30387edd05d7f1f4a45e24e905 (patch) | |
| tree | e3cc60bfd6574fc3c6fe76164e862de336d49dbe /src/qt/winshutdownmonitor.cpp | |
| parent | 2cbcc55ba6aea26d64eae3981b83dac04f70240f (diff) | |
| parent | 5224be5a3354e1a22ea4d7f0e40aadfccdf67064 (diff) | |
Merge #16231: gui: Fix open wallet menu initialization order
5224be5a3354e1a22ea4d7f0e40aadfccdf67064 gui: Fix open wallet menu initialization order (João Barbosa)
Pull request description:
Fixes #16230, the menu must be created before connecting to aboutToShow signal.
ACKs for commit 5224be:
hebasto:
ACK 5224be5a3354e1a22ea4d7f0e40aadfccdf67064, I have tested the code on Bionic with Qt 5.12.4.
ryanofsky:
utACK 5224be5a3354e1a22ea4d7f0e40aadfccdf67064. Looks good, fix is simple and makes perfect sense after seeing explanation in https://github.com/bitcoin/bitcoin/pull/16118#issuecomment-503166407. Without this change (and since #16118), the menu pointer passed to `connect(m_open_wallet_action->menu(), ...)` is null and connecting has no effect. With this change, the menu is constructed earlier so the connect call can work.
fanquake:
ACK 5224be5a3354e1a22ea4d7f0e40aadfccdf67064 Testing included in a comment above. The segfaulting with QT_FATAL_WARNINGS is unrelated to this change.
Tree-SHA512: 97b42493b37b96683058bccf39a0ee93589293d4ba8f0c60aef7f4fb9dd084cc6d5608cd5ef531cadf5e03b1f01627ef96bc2d79f784fb38cb87aa6643183d41
Diffstat (limited to 'src/qt/winshutdownmonitor.cpp')
0 files changed, 0 insertions, 0 deletions