diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-23 14:31:47 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-04-23 14:37:45 +0200 |
| commit | 4741ca5dc8fd364352ebae3ba9bfb701f1847d26 (patch) | |
| tree | 10805762aad32df1065ee301081a59200820985e /src/qt/walletmodel.cpp | |
| parent | 8b4081a889b35cac3ccafa4f7109c72ccb087518 (diff) | |
| parent | e4d0b44373c75a597c21a0e93698364fc33fb79d (diff) | |
| download | bitcoin-4741ca5dc8fd364352ebae3ba9bfb701f1847d26.tar.xz | |
Merge #13020: Consistently log CValidationState on call failure
e4d0b44 Consistently log CValidationState on failure (Ben Woosley)
Pull request description:
This replaces potential silent failures and partial logging with full logging. Seems providing at least minimal visibility to the failure is a good practice. E.g. `FlushStateToDisk` can return a rare but meaningful out of disk space error that would be better to note than leave out.
Note many of these are related to `ActivateBestChain` or `FlushStateToDisk`. Only a few cases of ignored state remain, e.g. LoadExternalBlockFile and RelayWalletTransaction, where I expect logging would likely be spammy.
Tree-SHA512: fb0e521039e5a5250cd9c82e7a8676423b5e3899d495649c0e71752059d1984e5175f556386ade048f51a7d59f5c8e467df7fe91d746076f97d24c000ccf7891
Diffstat (limited to 'src/qt/walletmodel.cpp')
0 files changed, 0 insertions, 0 deletions