diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-08-23 09:34:22 +0200 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-08-23 09:34:28 +0200 |
| commit | 489beb39842fd49393823953940510c28b169c95 (patch) | |
| tree | db6fbf8e77c4cd849ef26f52b732bac69e868889 /src/qt/transactionview.cpp | |
| parent | 58b559fab025f50fee991532426a9a6a8db3e88d (diff) | |
| parent | a3b559c970ada3c123ae24f21e45892734e7d494 (diff) | |
| download | bitcoin-489beb39842fd49393823953940510c28b169c95.tar.xz | |
Merge bitcoin/bitcoin#22641: test: Split rpc_signmessage test for disabled wallet
a3b559c970ada3c123ae24f21e45892734e7d494 test: added test for disabled wallet (Shubhankar Gambhir)
Pull request description:
This PR enables a part of the non-wallet functional test (rpc_signmessage.py) to be run even with the Bitcoin Core wallet disabled, it is inspired by #20078.
Divided tests in rpc_signmessage.py into 2 files wallet_signmessagewithaddress.py and rpc_signmessagewithprivkey.py, latter one can run even when wallet is disabled that provides extra test which was not performed earlier.
* we need bitcoincore wallet to run rpc_signmessage.py, but it is olny required for signing messages with address and not for signing messages wih private key, so latter one can be in a seperate test which can run without wallet
* verifying message doesn't require wallet, so it can be used in both tests without any problem
* 2 tests are named as wallet_signmessagewithaddress.py and rpc_signmessagewithprivkey.py to provide clarity of what they are testing.
ACKs for top commit:
vasild:
ACK a3b559c970ada3c123ae24f21e45892734e7d494
theStack:
Code-review ACK a3b559c970ada3c123ae24f21e45892734e7d494
Tree-SHA512: 1bfca3baf3123a02f0a2389e55e141d64430c3bed40ff5a5fb97ef2c66e2853c46e4b2dff62b948eb94dc574cb89d061769330f0535e2d5d1be76b60101136ac
Diffstat (limited to 'src/qt/transactionview.cpp')
0 files changed, 0 insertions, 0 deletions