diff options
| author | fanquake <fanquake@gmail.com> | 2023-05-26 12:15:35 +0100 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2023-05-26 13:09:26 +0100 |
| commit | 4d13fe47be175d01a59147e514da554a88028e10 (patch) | |
| tree | 190ca6ce739f1d38355ff04da07d23e7d5001af1 /src/qt/test | |
| parent | aa6cc5bec9e5d2a9bb2c54cb6d1c9d089c745d94 (diff) | |
| parent | 8aa8f73adce72e1ae855b43413c1f65504423cb7 (diff) | |
Merge bitcoin/bitcoin#25977: refactor: Replace `std::optional<bilingual_str>` with `util::Result`
8aa8f73adce72e1ae855b43413c1f65504423cb7 refactor: Replace std::optional<bilingual_str> with util::Result (Ryan Ofsky)
5f49cb1bc8e6ba0671c21bf6292d2d3de43fd001 util: Add void support to util::Result (MarcoFalke)
Pull request description:
Replace uses of `std::optional<bilingual_str>` with `util::Result` as suggested https://github.com/bitcoin/bitcoin/pull/25648#discussion_r936311768, https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1192007516, https://github.com/bitcoin/bitcoin/pull/27632#discussion_r1194858242, https://github.com/bitcoin/bitcoin/pull/24313#discussion_r1204047087
ACKs for top commit:
MarcoFalke:
very nice ACK 8aa8f73adce72e1ae855b43413c1f65504423cb 🏏
TheCharlatan:
ACK 8aa8f73adce72e1ae855b43413c1f65504423cb7
hebasto:
ACK 8aa8f73adce72e1ae855b43413c1f65504423cb7, I have reviewed the code and it looks OK.
Tree-SHA512: 6c2f218bc445184ce93ec2b907e61666a05f26f2c9447f69fcb504aa8291b0c693d913f659dfd19813a9e24615546c72cbe2ca419218fd867ff0694c4a1b6a30
Diffstat (limited to 'src/qt/test')
0 files changed, 0 insertions, 0 deletions