aboutsummaryrefslogtreecommitdiff
path: root/src/qt/test/addressbooktests.cpp
diff options
context:
space:
mode:
authorRussell Yanofsky <russ@yanofsky.org>2018-08-20 15:24:55 -0400
committerRussell Yanofsky <russ@yanofsky.org>2018-08-20 15:24:55 -0400
commita3197c5294df4711bab0ff6dcdd061ceab115c7d (patch)
tree48671933685369a552bae6bc4bf3e0c8bdfd7a96 /src/qt/test/addressbooktests.cpp
parent2a583406c00761c0ac1d162531256b401d5b16c3 (diff)
downloadbitcoin-a3197c5294df4711bab0ff6dcdd061ceab115c7d.tar.xz
Disable wallet and address book Qt tests on macOS minimal platform
macOS Qt minimal platform is frequently broken, and these are currently failing with Qt 5.11.1. The tests do pass when run on the full cocoa platform (with `test_bitcoin-qt -platform cocoa`).
Diffstat (limited to 'src/qt/test/addressbooktests.cpp')
-rw-r--r--src/qt/test/addressbooktests.cpp12
1 files changed, 12 insertions, 0 deletions
diff --git a/src/qt/test/addressbooktests.cpp b/src/qt/test/addressbooktests.cpp
index c3d33c76d4..3525846044 100644
--- a/src/qt/test/addressbooktests.cpp
+++ b/src/qt/test/addressbooktests.cpp
@@ -17,6 +17,7 @@
#include <key_io.h>
#include <wallet/wallet.h>
+#include <QApplication>
#include <QTimer>
#include <QMessageBox>
@@ -139,5 +140,16 @@ void TestAddAddressesToSendBook()
void AddressBookTests::addressBookTests()
{
+#ifdef Q_OS_MAC
+ if (QApplication::platformName() == "minimal") {
+ // Disable for mac on "minimal" platform to avoid crashes inside the Qt
+ // framework when it tries to look up unimplemented cocoa functions,
+ // and fails to handle returned nulls
+ // (https://bugreports.qt.io/browse/QTBUG-49686).
+ QWARN("Skipping AddressBookTests on mac build with 'minimal' platform set due to Qt bugs. To run AppTests, invoke "
+ "with 'test_bitcoin-qt -platform cocoa' on mac, or else use a linux or windows build.");
+ return;
+ }
+#endif
TestAddAddressesToSendBook();
}