diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2022-01-20 18:10:47 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2022-01-20 18:10:56 +0100 |
| commit | b60c477d54bba12c1d484be36f75a59ce54d534a (patch) | |
| tree | ce51566ee5b0ac9311b4dedeebf48a4590f7afc9 /src/qt/rpcconsole.cpp | |
| parent | 1824644a363bf4adfb54cf32ab63806808fe778b (diff) | |
| parent | faedb111d2df78eabddaeccaba42f47572388bc7 (diff) | |
Merge bitcoin/bitcoin#23629: refactor tests to fix ubsan suppressions
faedb111d2df78eabddaeccaba42f47572388bc7 refactor tests to fix ubsan suppressions (MarcoFalke)
Pull request description:
The ubsan suppressions for test files have several issues:
* They bloat the suppressions file, distracting from real bugs
* They are file-wide, thus suppressing any other (newly introduced) issues in the same file
* Some of them are causing compile issues with -Wimplicit-int-conversion
Fix all issues by making the integer truncations or sign changes explicit.
This is a refactor that shouldn't change the test binary unless compiled with sanitizers.
ACKs for top commit:
jonatack:
ACK faedb111d2df78eabddaeccaba42f47572388bc7 per `git range-diff 1824644a fa9bab0 faedb11` and clang 13 debug build sanity check
Tree-SHA512: a1a6aaf2cf52562a49220375deb10062b388c1ccb7ddcd9ef2a8e6b9873961c5b285704799589b7dd5579f3db8692ba72a9d622172b4e4d2423534cd550e8859
Diffstat (limited to 'src/qt/rpcconsole.cpp')
0 files changed, 0 insertions, 0 deletions