diff options
| author | Jonas Schnelli <dev@jonasschnelli.ch> | 2019-08-16 08:21:26 +0200 |
|---|---|---|
| committer | Jonas Schnelli <dev@jonasschnelli.ch> | 2019-08-16 08:22:54 +0200 |
| commit | 93bacb8cc9c05010659d9aea463ebac5c1b6bf39 (patch) | |
| tree | 364fbb124e1c4e583b28bc1cb62b06907244cf25 /src/qt/res/icons/about_qt.png | |
| parent | 0d65106dce281a1a09a69c5fe56be6c1cb523882 (diff) | |
| parent | 390874c722c5af0b37cb94151ffb49986eab5f7d (diff) | |
Merge #16612: qt: Remove menu icons
390874c722c5af0b37cb94151ffb49986eab5f7d qt: Remove menu icons (Wladimir J. van der Laan)
Pull request description:
Remove the icons from the application menu. Why remove?
- They are inconsistently applied, some actions had icons, some newer ones don't. Good luck coming up with a sensible icon for everything
- Menu icons don't seem to have a place in modern UI: for example, GNOME, MacOS have stopped showing these a long time ago (see https://github.com/bitcoin/bitcoin/pull/16584#issuecomment-521195090)
- Less bikeshedding opportunity about "what should the icon for this be"
Removed icons:
```
/icons/quit res/icons/quit.png
/icons/about res/icons/about.png
/icons/about_qt res/icons/about_qt.png
/icons/options res/icons/configure.png
/icons/key res/icons/key.png
/icons/verify res/icons/verify.png (also .svg)
/icons/debugwindow res/icons/debugwindow.png
/icons/open res/icons/open.png
/icons/info res/icons/info.png
/icons/filesave res/icons/filesave.png
```
I checked that these icons are used nowhere else.
Removed from the menu not removed from the repository, because still referenced by other parts of the code:
```
/icons/lock_closed
/icons/edit
/icons/address-book
/icons/send
```
ACKs for top commit:
practicalswift:
ACK 390874c722c5af0b37cb94151ffb49986eab5f7d -- diff looks correct
l2a5b1:
ACK 390874c722c5af0b37cb94151ffb49986eab5f7d - Bitcoin Core has a very simple application menu. As long as the menu items describe their actions clearly and unambiguously then the icons alongside the label are redundant and offer very little value, if anything at all.
kallewoof:
ACK 390874c722c5af0b37cb94151ffb49986eab5f7d
jonasschnelli:
utACK 390874c722c5af0b37cb94151ffb49986eab5f7d
Tree-SHA512: dd1c52bed3bc6fb9359d5ea1b229a023dafaf813ae640775cbb433b9886bbc11a7d6a4306bac350b26d45fca9b495e4468630f2a32e185570e05f16a3ce45b47
Diffstat (limited to 'src/qt/res/icons/about_qt.png')
| -rw-r--r-- | src/qt/res/icons/about_qt.png | bin | 2240 -> 0 bytes |
1 files changed, 0 insertions, 0 deletions
diff --git a/src/qt/res/icons/about_qt.png b/src/qt/res/icons/about_qt.png Binary files differdeleted file mode 100644 index c40abfd3a6..0000000000 --- a/src/qt/res/icons/about_qt.png +++ /dev/null |
