diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-02-23 14:03:24 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-02-23 14:03:29 +0100 |
| commit | 84f6c695c6a2f2126ef693dc8c22e7a579c47b7f (patch) | |
| tree | daf1dff33be17bae397eced813c78c6d253903c8 /src/qt/psbtoperationsdialog.cpp | |
| parent | c263c3d7d2a4b85fe133c5d8018c6ec53b8c942a (diff) | |
| parent | 5e531e6beb5381c0be5efaa24b7e423e593568e4 (diff) | |
| download | bitcoin-84f6c695c6a2f2126ef693dc8c22e7a579c47b7f.tar.xz | |
Merge #21274: assumptions: Assume C++17
5e531e6beb5381c0be5efaa24b7e423e593568e4 assumptions: check C++17 assumption with MSVC (fanquake)
c7b46489f8c4d880382248fb47266d81948bbce0 assumptions: assume a C++17 compiler (fanquake)
Pull request description:
This has been the case since #20413.
This should also enable the check for MSVC. From my reading of https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-160 and https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/ if we set the `/Zc:__cplusplus` switch in additional options, MSVC will report the correct value for `__cplusplus`. However I have not tested this.
ACKs for top commit:
laanwj:
Code review ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4
hebasto:
ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4, checked the MS docs, and AppVeyor build is green.
practicalswift:
ACK 5e531e6beb5381c0be5efaa24b7e423e593568e4
Tree-SHA512: a4fb525cf5c33abc944c614edb0313a39c8a39a1637a03c09342c15ba0925f4eb037062e65e51b42ade667506b7e554c7159acf86e6b8c35d0a87dd79a6f239b
Diffstat (limited to 'src/qt/psbtoperationsdialog.cpp')
0 files changed, 0 insertions, 0 deletions