diff options
| author | fanquake <fanquake@gmail.com> | 2019-10-17 14:53:13 -0400 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-10-17 14:53:33 -0400 |
| commit | 4daadce36cfe9baa63c4d7d70de027add03a00df (patch) | |
| tree | 527268408d0a40b257db15494ff76fc613bc087c /src/qt/modaloverlay.h | |
| parent | 88eff969c201db30be0d18f1541d33365087e7da (diff) | |
| parent | fa0467326ff004a0a20c6af9c8f6adcc74a0c8af (diff) | |
| download | bitcoin-4daadce36cfe9baa63c4d7d70de027add03a00df.tar.xz | |
Merge #17162: chain: Remove CBlockIndex::SetNull helper
fa0467326ff004a0a20c6af9c8f6adcc74a0c8af chain: Set all CBlockIndex members to null, remove SetNull helper (MarcoFalke)
Pull request description:
The first commit removes the `SetNull` helper and inlines the member initialization (C++11). See https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#c-data-structures for rationale.
<strike>The second commit adds the `cs_main` lock annotation to `RaiseValidity`. See also #17161.</strike>
ACKs for top commit:
promag:
Code review ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af.
practicalswift:
ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af -- diff still looks correct :)
laanwj:
ACK fa0467326ff004a0a20c6af9c8f6adcc74a0c8af, this makes it easy to see that all fields are initialized.
Tree-SHA512: 1b2b9fb0951c03c75b9cce322b89d4ecc9a364ae78b94d91b0b4669437824394dfada820ab6f74dfac3193f602899abfdc244ae2d9351ad293f555488f03470e
Diffstat (limited to 'src/qt/modaloverlay.h')
0 files changed, 0 insertions, 0 deletions