diff options
author | MarcoFalke <falke.marco@gmail.com> | 2020-08-26 16:32:03 +0200 |
---|---|---|
committer | MarcoFalke <falke.marco@gmail.com> | 2020-08-26 16:32:44 +0200 |
commit | 93ab136a33e46080c8aa02d59fb7c2a8d03a3387 (patch) | |
tree | 8c76ab65ae45db775f989f4269fbba7ee2e0fad4 /src/qt/guiutil.h | |
parent | a12d9e5fd24a25bef476c10620317e43a5905754 (diff) | |
parent | 519cae8fd6e44aef3470415d7c5e12acb0acd9f4 (diff) | |
download | bitcoin-93ab136a33e46080c8aa02d59fb7c2a8d03a3387.tar.xz |
Merge bitcoin-core/gui#35: Parse params directly instead of through node (partial revert #10244)
519cae8fd6e44aef3470415d7c5e12acb0acd9f4 gui: Delay interfaces::Node initialization (Russell Yanofsky)
102abff9eb6c267af64f2a3560712147d1896e13 gui: Replace interface::Node references with pointers (Russell Yanofsky)
91aced7c7e6e75c1f5896b7e3843015177f32748 gui: Remove unused interfaces::Node references (Russell Yanofsky)
e1336316250ab5cb0ed654b1e593378a6e0769ce gui: Partially revert #10244 gArgs and Params changes (Russell Yanofsky)
Pull request description:
This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).
---
This is a partial revert of https://github.com/bitcoin/bitcoin/pull/10244. It changes gui code to go back to using gArgs and Params() functions directly instead of using interfaces::Node to handle arguments.
These changes were originally pushed as part of https://github.com/bitcoin/bitcoin/pull/19461. Motivation is to support a new GUI process connecting to an already running node process. Details are explained in commit messages, but in addition to spawning a new bitcoin-node process, we want bitcoin-gui to connect to an existing bitcoin-node process. So for that reason it should be able to parse its own parameters, rather than rely on the node.
ACKs for top commit:
MarcoFalke:
re-ACK 519cae8fd6, only change is rebase and addressed nits of my previous review last week 🌄
Tree-SHA512: 9c339dd82ba78bcc7b887b84d872f35ccc7dfa3d271691e6eafe8a2048cbbe3bdde1e810ce33d0714d75d048c9de3470e9e9b6f8306a6047d1cb3548f6858dc8
Diffstat (limited to 'src/qt/guiutil.h')
0 files changed, 0 insertions, 0 deletions