diff options
author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-01-29 19:59:17 +0100 |
---|---|---|
committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2021-01-29 20:08:22 +0100 |
commit | 16b784d953365bb2d7ae65acd2b20a79ef8ba7b6 (patch) | |
tree | e4db3caebe2358d2791af8c2f7c65791900600c2 /src/qt/guiutil.cpp | |
parent | c8b83510f42c6959c2844b8b81a6590dd3a34e65 (diff) | |
parent | c86b9a65eb0d6d1e659415880702c4dc889c34e6 (diff) | |
download | bitcoin-16b784d953365bb2d7ae65acd2b20a79ef8ba7b6.tar.xz |
Merge #20689: contrib: replace binary verification script verify.sh with python rewrite
c86b9a65eb0d6d1e659415880702c4dc889c34e6 contrib: remove verify.sh (Sebastian Falbesoner)
c84838e7afb7b084a56a75e98325563b6de83124 contrib: binary verification script verify.sh rewritten in python (Sebastian Falbesoner)
Pull request description:
The rationale for the PR is the same as for #18132:
> Most of our test scripts are written in python. We don't have enough reviewers for bash scripts and they tend to be clumsy anyway. Especially when it comes to argument parsing.
Note that there are still a lot of things that could be improved in this replacement (e.g. using regexps for version string parsing, adding type annotations, dividing up into more functions, getting a pylint score closer to 10, etc.), but I found the original shell script quite hard to read, so it's possibly still a good first step for an improvement.
~Not sure though if it's worth the reviewers time, and if it's even continued to be used long-term (maybe there are plans to merge it with `get_previous_releases.py`, which partly does the same?), so chasing for Concept ACKs right now.~
ACKs for top commit:
laanwj:
Tested and code review ACK c86b9a65eb0d6d1e659415880702c4dc889c34e6
Tree-SHA512: f7949eead4ef7e5913fe273923ae5c5299408db485146cf996cdf6f8ad8c0ee4f4b30bb6b08a5964000d97b2ae2e7a1bdc88d11c613c16d2d135d80b444e3b16
Diffstat (limited to 'src/qt/guiutil.cpp')
0 files changed, 0 insertions, 0 deletions