diff options
| author | merge-script <32963518+hebasto@users.noreply.github.com> | 2024-05-11 19:13:34 +0100 |
|---|---|---|
| committer | merge-script <32963518+hebasto@users.noreply.github.com> | 2024-05-11 19:13:34 +0100 |
| commit | 182983c6ab2e037d65303fa13148f39236f2734a (patch) | |
| tree | e97596000cb9907a66077d02ce05de5f82801eec /src/qt/forms | |
| parent | b47c393d8a39b48a8f17f2d8abae9ba2f2bf5a61 (diff) | |
| parent | 3bf00e13609eefa6ddb11353519bb1aec2342513 (diff) | |
Merge bitcoin-core/gui#788: debugwindow: update session ID tooltip
3bf00e13609eefa6ddb11353519bb1aec2342513 gui: debugwindow: update session ID tooltip (Marnix)
Pull request description:
When you have a v2 connection, there is always a session ID.
the _if any_ is a leftover from https://github.com/bitcoin-core/gui/pull/754, where the session ID property initially would always be displayed (transport v1 and v2).
So the session ID could be empty when you have a v1 connection.
As now the _Session ID_ property only is displayed for v2 connection, there will always be a session ID.
master
PR
Session ID not shown when transport v1
<!--
*** Please remove the following help text before submitting: ***
Pull requests without a rationale and clear improvement may be closed
immediately.
GUI-related pull requests should be opened against
https://github.com/bitcoin-core/gui
first. See CONTRIBUTING.md
-->
<!--
Please provide clear motivation for your patch and explain how it improves
Bitcoin Core user experience or Bitcoin Core developer experience
significantly:
* Any test improvements or new tests that improve coverage are always welcome.
* All other changes should have accompanying unit tests (see `src/test/`) or
functional tests (see `test/`). Contributors should note which tests cover
modified code. If no tests exist for a region of modified code, new tests
should accompany the change.
* Bug fixes are most welcome when they come with steps to reproduce or an
explanation of the potential issue as well as reasoning for the way the bug
was fixed.
* Features are welcome, but might be rejected due to design or scope issues.
If a feature is based on a lot of dependencies, contributors should first
consider building the system outside of Bitcoin Core, if possible.
* Refactoring changes are only accepted if they are required for a feature or
bug fix or otherwise improve developer experience significantly. For example,
most "code style" refactoring changes require a thorough explanation why they
are useful, what downsides they have and why they *significantly* improve
developer experience or avoid serious programming bugs. Note that code style
is often a subjective matter. Unless they are explicitly mentioned to be
preferred in the [developer notes](/doc/developer-notes.md), stylistic code
changes are usually rejected.
-->
<!--
Bitcoin Core has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial time
effort to review. There is a huge lack of active reviewers on the project, so
patches often sit for a long time.
-->
ACKs for top commit:
vostrnad:
ACK 3bf00e13609eefa6ddb11353519bb1aec2342513
kristapsk:
ACK 3bf00e13609eefa6ddb11353519bb1aec2342513
jarolrod:
ACK 3bf00e13609eefa6ddb11353519bb1aec2342513
pablomartin4btc:
tACK 3bf00e13609eefa6ddb11353519bb1aec2342513
hebasto:
ACK 3bf00e13609eefa6ddb11353519bb1aec2342513.
Tree-SHA512: 4de0c56c070dc5d1cee73b629bdf3d1778c6d90d512337aa6cfd3eed4ce95cbcfbe5713e2942f6fc22907b2c4d9df7979ba8e9f91f7cc173b42699ea35113f96
Diffstat (limited to 'src/qt/forms')
| -rw-r--r-- | src/qt/forms/debugwindow.ui | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qt/forms/debugwindow.ui b/src/qt/forms/debugwindow.ui index 60e9bcde33..eeea53864a 100644 --- a/src/qt/forms/debugwindow.ui +++ b/src/qt/forms/debugwindow.ui @@ -1113,7 +1113,7 @@ <item row="3" column="0"> <widget class="QLabel" name="peerSessionIdLabel"> <property name="toolTip"> - <string>The BIP324 session ID string in hex, if any.</string> + <string>The BIP324 session ID string in hex.</string> </property> <property name="text"> <string>Session ID</string> |