diff options
| author | W. J. van der Laan <laanwj@protonmail.com> | 2021-10-01 10:30:26 +0200 |
|---|---|---|
| committer | W. J. van der Laan <laanwj@protonmail.com> | 2021-10-01 10:32:10 +0200 |
| commit | 46b4937bc16cbccabaf27ca9c1d605646bdea67e (patch) | |
| tree | 6de43c39c746a9f451d852c736c343a28a15df48 /src/qt/coincontroldialog.h | |
| parent | 29b030bca31d1246e94b3396b0a01a17dadc96a8 (diff) | |
| parent | 0ab4c3b27265401c59e40adc494041927dc9dbe3 (diff) | |
Merge bitcoin/bitcoin#23142: Return false on corrupt tx rather than asserting
0ab4c3b27265401c59e40adc494041927dc9dbe3 Return false on corrupt tx rather than asserting (Samuel Dobson)
Pull request description:
Takes up #19793
Rather than asserting, we log an error and return CORRUPT so that the user is informed. This type of error isn't critical so it isn't worth `assert`ing.
ACKs for top commit:
achow101:
ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3
laanwj:
Code review ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3
ryanofsky:
Code review ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3. There may be room for more improvements later like better error messages or easier recovery options, but changing from an assert to an error seems like a clear improvement, and this seems to avoid all the pitfalls of the last PR that tried this.
Tree-SHA512: 4a1a412e7c473d176c4e09123b85f390a6b0ea195e78d28ebd50b13814b7852f8225a172511a2efb6affb555b11bd4e667c19eb8c78b060c5444b62f0fae5f7a
Diffstat (limited to 'src/qt/coincontroldialog.h')
0 files changed, 0 insertions, 0 deletions