diff options
| author | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-16 13:34:01 +0200 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@protonmail.com> | 2019-09-16 13:46:39 +0200 |
| commit | cd737214ced756898883c8d940d353f0a1c4f4b9 (patch) | |
| tree | ea797094c2f78a11be2a396c6670486e95415295 /src/qt/bitcoinunits.h | |
| parent | eb812257a3fd2b829131f9fead71ab030e87d9e7 (diff) | |
| parent | fae961de6be3e2ab9793d437079651541e219e71 (diff) | |
Merge #16737: test: Establish only one connection between nodes in rpc_invalidateblock
fae961de6be3e2ab9793d437079651541e219e71 test: Establish only one connection between nodes in rpc_invalidateblock (MarcoFalke)
Pull request description:
Headers and block sync should eventually converge to the same result, regardless of whether the peers treat each other as "inbound" or "outbound".
`connect_nodes_bi` has been introduced as a (temporary?) workaround for bug #5113 and #5138, which has long been fixed in #5157 and #5662.
Thus remove the `connect_nodes_bi` workaround from the rpc_invalidateblock test.
Conveniently, this also closes #16453. See https://github.com/bitcoin/bitcoin/issues/16444#issuecomment-514801708 for rationale
ACKs for top commit:
laanwj:
ACK fae961de6be3e2ab9793d437079651541e219e71
Tree-SHA512: b3614c66a205823df73f64d19cacfbec269beb5db52ff79004d746e17d7c0dfb43ab9785fdddc97e2a76fe76286c8c605b34df3dda4a2bf5be035f01169ae89a
Diffstat (limited to 'src/qt/bitcoinunits.h')
0 files changed, 0 insertions, 0 deletions