diff options
| author | fanquake <fanquake@gmail.com> | 2019-07-23 12:22:58 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-07-23 12:42:24 +0800 |
| commit | 848f245d04b604abcae84dcb9f0f6078325d418d (patch) | |
| tree | 33ff897dbc61f12368bfac8957d26dc69c8cdaea /src/qt/bitcoingui.cpp | |
| parent | ad4391ca384bf04a994781c2ec3486a579c90265 (diff) | |
| parent | 4f050b91c706181084b9288b8a87b7b637e4e4f7 (diff) | |
| download | bitcoin-848f245d04b604abcae84dcb9f0f6078325d418d.tar.xz | |
Merge #16355: refactor: move CCoinsViewErrorCatcher out of init.cpp
4f050b91c706181084b9288b8a87b7b637e4e4f7 move-onlyish: move CCoinsViewErrorCatcher out of init.cpp (James O'Beirne)
Pull request description:
This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11):
Parent PR: #15606
Issue: #15605
Specification: https://github.com/jamesob/assumeutxo-docs/tree/2019-04-proposal/proposal
---
This change moves `CCoinsViewErrorCatcher` out of `init` and into `coins` so that it can later be included in [a `CoinsView` instance](https://github.com/bitcoin/bitcoin/pull/15606/commits/91284964ef34b90ee6c626137973d2c15e7b25da#diff-349fbb003d5ae550a2e8fa658e475880R504) under `CChainState`.
Instead of hardcoding read failure behavior that has knowledge of qt, it accepts error callbacks via `AddReadErrCallback()`.
ACKs for top commit:
dongcarl:
re-ACK 4f050b91c706181084b9288b8a87b7b637e4e4f7
ryanofsky:
utACK 4f050b91c706181084b9288b8a87b7b637e4e4f7. Only change since last review is fixing const.
Tree-SHA512: eaba21606d15d2b8d0e3db7cec57779ce181af953db1ef4af80a0bc1dfb57923d0befde9d61b7be55c32224744f7fb6bd47d4e4c72f3ccfe6eaf0f4ae3765c17
Diffstat (limited to 'src/qt/bitcoingui.cpp')
0 files changed, 0 insertions, 0 deletions