diff options
| author | fanquake <fanquake@gmail.com> | 2019-08-15 15:03:41 +0800 |
|---|---|---|
| committer | fanquake <fanquake@gmail.com> | 2019-08-15 15:19:35 +0800 |
| commit | 8fc7f0cba9b1b60ce25d6a8ba51052af1461f825 (patch) | |
| tree | 622cf108476456cb37c098aee2441f828f54440f /src/qt/bitcoin.h | |
| parent | 8516285d2ea4c2c92a3cb57459dbbe7e7748b2e2 (diff) | |
| parent | a2714a5c69f0b0506689af04c3e785f71ee0915d (diff) | |
Merge #16578: Do not pass in command line arguments to QApplication
a2714a5c69f0b0506689af04c3e785f71ee0915d Give QApplication dummy arguments (Andrew Chow)
Pull request description:
QApplication takes the command line arguments and parses them itself for some [built in command line arguments](https://doc.qt.io/qt-5/qapplication.html#QApplication) that it has. We don't want any of those built in arguments, so instead give it dummy arguments.
To test, you can use the `-reverse` option. Without this patch, everything will appear right-to-left; things that were on the left side will be on the right and everything is right aligned.
After this patch, `-reverse` will now give a startup error since we do not support this argument.
ACKs for top commit:
laanwj:
ACK a2714a5c69f0b0506689af04c3e785f71ee0915d
hebasto:
ACK a2714a5c69f0b0506689af04c3e785f71ee0915d
fanquake:
ACK a2714a5c69f0b0506689af04c3e785f71ee0915d - Have tested that arguments like `-reverse` are no longer being passed through and result in an error.
Tree-SHA512: 983bd948ca6999f895b6662b58c37e33af7ed61fdd600c6b4623febb87ec06a92c66e3b3300783530110cc711902793ef82d751d7f563696c4c3a8416b2b1f51
Diffstat (limited to 'src/qt/bitcoin.h')
| -rw-r--r-- | src/qt/bitcoin.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/qt/bitcoin.h b/src/qt/bitcoin.h index 40537c1813..3869193a3a 100644 --- a/src/qt/bitcoin.h +++ b/src/qt/bitcoin.h @@ -56,7 +56,7 @@ class BitcoinApplication: public QApplication { Q_OBJECT public: - explicit BitcoinApplication(interfaces::Node& node, int &argc, char **argv); + explicit BitcoinApplication(interfaces::Node& node); ~BitcoinApplication(); #ifdef ENABLE_WALLET |