diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2019-08-02 08:53:34 -0400 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2019-08-02 08:53:39 -0400 |
| commit | d759b5d26a7e7cf381d80a5a0390787a136042e9 (patch) | |
| tree | 389a182869ac97b4251690d20e1f4666a7c23d7e /src/qt/bitcoin.cpp | |
| parent | 9f54e9ab9038e33f97ced19d127cb8622197656f (diff) | |
| parent | d6b3640ac732f6f66a8cb6761084d1beecc8a876 (diff) | |
| download | bitcoin-d759b5d26a7e7cf381d80a5a0390787a136042e9.tar.xz | |
Merge #15911: Use wallet RBF default for walletcreatefundedpsbt
d6b3640ac732f6f66a8cb6761084d1beecc8a876 [test] walletcreatefundedpsbt: check RBF is disabled when -walletrbf=0 (Sjors Provoost)
9ed062b5685eb6227d694572cb0f7bfbcc151b36 [doc] rpc: remove "fallback to" from RBF default help (Sjors Provoost)
4fcb698bc2bb74171cd3a14b94f9882d8e19e9fb [rpc] walletcreatefundedpsbt: use wallet default RBF (Sjors Provoost)
Pull request description:
The `walletcreatefundedpsbt` RPC call currently ignores `-walletrbf` and defaults to not use RBF. This PR fixes that.
This PR also replaces UniValue in `ConstructTransaction` with a `bool` in preparation of moving this helper method out of the RPC codebase entirely. This may be a bit overkill, but does slightly simplify it.
Fixes #15878
ACKs for top commit:
achow101:
Code Review ACK d6b3640ac732f6f66a8cb6761084d1beecc8a876
l2a5b1:
re-ACK d6b3640
MarcoFalke:
ACK d6b3640ac732f6f66a8cb6761084d1beecc8a876
Tree-SHA512: 55b9bccd1ef36b54f6b34793017dc0721103099ad3761b3b04862291ee13d6915915d4dbb1a8567924fa56e5e95dfe10eec070e06701610e70c87f8ea92b2a00
Diffstat (limited to 'src/qt/bitcoin.cpp')
0 files changed, 0 insertions, 0 deletions