aboutsummaryrefslogtreecommitdiff
path: root/src/protocol.h
diff options
context:
space:
mode:
authorpracticalswift <practicalswift@users.noreply.github.com>2017-06-01 16:13:35 +0200
committerpracticalswift <practicalswift@users.noreply.github.com>2017-09-22 14:59:27 +0200
commit9ad6746ccd6dc31141fd0144686b641e31bf626b (patch)
treea5f2a33bef9eae6fde623ba8fd9233f1bb9942a4 /src/protocol.h
parent98212745c8acb5cc4e688bbb3979bfd46b25f98a (diff)
Use static_cast instead of C-style casts for non-fundamental types
A C-style cast is equivalent to try casting in the following order: 1. const_cast(...) 2. static_cast(...) 3. const_cast(static_cast(...)) 4. reinterpret_cast(...) 5. const_cast(reinterpret_cast(...)) By using static_cast<T>(...) explicitly we avoid the possibility of an unintentional and dangerous reinterpret_cast. Furthermore static_cast<T>(...) allows for easier grepping of casts.
Diffstat (limited to 'src/protocol.h')
-rw-r--r--src/protocol.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/protocol.h b/src/protocol.h
index 67e01d9606..8e974c372a 100644
--- a/src/protocol.h
+++ b/src/protocol.h
@@ -301,8 +301,8 @@ public:
READWRITE(nTime);
uint64_t nServicesInt = nServices;
READWRITE(nServicesInt);
- nServices = (ServiceFlags)nServicesInt;
- READWRITE(*(CService*)this);
+ nServices = static_cast<ServiceFlags>(nServicesInt);
+ READWRITE(*static_cast<CService*>(this));
}
// TODO: make private (improves encapsulation)