diff options
author | fanquake <fanquake@gmail.com> | 2020-08-27 15:34:54 +0800 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2020-08-27 16:03:14 +0800 |
commit | 2562d5d23863b6ef6cbdd9c34db5e485d9dc8406 (patch) | |
tree | 31e2f34f9c700f993b1318ff4c141de665755119 /src/protocol.h | |
parent | 28f4e53e168fe09b3ed9b811f12e1f990a304264 (diff) | |
parent | 3de365e4f15ddaaf6bdb5b3c31529156617d2835 (diff) | |
download | bitcoin-2562d5d23863b6ef6cbdd9c34db5e485d9dc8406.tar.xz |
Merge #19761: build: improve sed robustness by not using sed
3de365e4f15ddaaf6bdb5b3c31529156617d2835 build: replace wingenminiupnpcstrings sed with a patch in miniupnpc package (fanquake)
bbc01a753d40488fa1469c87b31e7a12ddc8b329 build: replace qtranslations lrelease sed with a patch in qt package (fanquake)
c723e4176ee3c1c2391a7c43b094a315bdd3c72e build: replace FreeType back-compat sed with a patch in qt package (fanquake)
3aaa39d436aa32489aa136d6b3d714220535ec1e build: replace pwd sed in qt package with a patch (fanquake)
9d440f4e11f7d610f3bcf1fb587d71ed2581a6c1 build: remove no-longer needed qt workaround (fanquake)
bf85eace1a594862c4baa375fd3c8b741948cc47 build: remove no-longer needed qt configure workaround (fanquake)
4af59a407a207e7de327c1bb145d68ebc8ddedd8 build: use patch rather than sed in zeromq package (fanquake)
cc107a3af17d821f66de9357efe73214a628803b build: use patch rather than sed in native_cctools package (fanquake)
865cb23a485d88be603c1d6bf8c32ef7a5edeaa2 build: use patch rather than sed in fontconfig package (fanquake)
335bd7f8bc415d6419763e17b013f94e5f0e5689 build: use patch rather than sed in Boost package (fanquake)
f36140d00c937b5059cd952d759a77e25330388a build: use patch rather than sed in bdb package (fanquake)
Pull request description:
While using `sed` can be handy to use for a quick-fix, these instances accumulate, and can become unmaintainable. Not only that, but using sed isn't necessarily robust and it can fail silently. Most of our usage is also missing any documentation explaining why something is being done, when it should be updated/removed etc.
Rather than relying on sed going forward, where possible, I've converted our sed usage into patches. These are easier to maintain, contain documentation, and should fail loudly when they don't apply.
The remaining sed usage, (1 in miniupnpc, the rest in qt), are non-trivial to remove, as they are using build-time variables, or some input from the environment.
This also steals 2 related commits out of #19716.
Related to #16838.
ACKs for top commit:
hebasto:
re-ACK 3de365e4f15ddaaf6bdb5b3c31529156617d2835, only `drop_lrelease_dependency.patch` updated. Travis makes ARM build without errors now.
theuni:
ACK 3de365e4f15ddaaf6bdb5b3c31529156617d2835.
Tree-SHA512: b39afcb237e4421f9caabbd665af93fd2e749a1cdd42b1d5ee2261059120005c0e82994d315e679c317d23794eab5c7727f51cae403c94a9c4e4fd7eee9e7ee6
Diffstat (limited to 'src/protocol.h')
0 files changed, 0 insertions, 0 deletions