diff options
| author | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-02-06 18:05:11 +0100 |
|---|---|---|
| committer | Wladimir J. van der Laan <laanwj@gmail.com> | 2018-02-06 18:05:34 +0100 |
| commit | 1462bde767a121233118c04c5629bd9de1ba0f16 (patch) | |
| tree | 814e7e384c9cdf0517ef23fe84d5f4f7a681ed59 /src/protocol.h | |
| parent | 5ad320598f06370de65f83b6c6a993123f00b329 (diff) | |
| parent | bdb3231bee7a729a94045133fc4335226b2b0bb9 (diff) | |
Merge #12050: [trivial] Implements a virtual destructor on the BaseRequestHandler class.
bdb3231 Implements a virtual destructor on the BaseRequestHandler class. (251)
Pull request description:
Granted that there is no undefined behavior in the current implementation, this PR implements a virtual destructor on the BaseRequestHandler class to protect against undefined behavior in the event that an object of a potential future derived BaseRequestHandler class with a destructor is destroyed through a pointer to this base class.
This PR also fixes "_warning: delete called on 'BaseRequestHandler' that is abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]_" warnings in environments where the project is built with the `-Wsystem-headers` flag; or environments where the `-Wdelete-non-virtual-dtor` diagnostics flag fires from system headers.
Tree-SHA512: 3c3b0797a8dbce8d8c5b244709e8bca41c4e28d5ba554a974bf7fc9128413e1098c457a00e51b21154ce6c11ce5da3071626e71d593b2550d0020bc589406eed
Diffstat (limited to 'src/protocol.h')
0 files changed, 0 insertions, 0 deletions