diff options
| author | Elichai Turkel <elichai.turkel@gmail.com> | 2020-03-19 14:57:02 +0200 |
|---|---|---|
| committer | Elichai Turkel <elichai.turkel@gmail.com> | 2020-03-23 16:36:24 +0200 |
| commit | f65c9ad40f2f5cdc581bdaf72e7dc68e9d7f7a80 (patch) | |
| tree | 8d7d4e3fbc104e2a689a592a4d42fbe41c9ae63a /src/primitives | |
| parent | 67de1ee8bc18afff0f2f9f203803467a2274bfc1 (diff) | |
| download | bitcoin-f65c9ad40f2f5cdc581bdaf72e7dc68e9d7f7a80.tar.xz | |
Check for overflow when calculating sum of outputs
Diffstat (limited to 'src/primitives')
| -rw-r--r-- | src/primitives/transaction.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/primitives/transaction.cpp b/src/primitives/transaction.cpp index 28c145f71d..6e72c1f15c 100644 --- a/src/primitives/transaction.cpp +++ b/src/primitives/transaction.cpp @@ -9,6 +9,8 @@ #include <tinyformat.h> #include <util/strencodings.h> +#include <assert.h> + std::string COutPoint::ToString() const { return strprintf("COutPoint(%s, %u)", hash.ToString().substr(0,10), n); @@ -84,10 +86,11 @@ CAmount CTransaction::GetValueOut() const { CAmount nValueOut = 0; for (const auto& tx_out : vout) { - nValueOut += tx_out.nValue; - if (!MoneyRange(tx_out.nValue) || !MoneyRange(nValueOut)) + if (!MoneyRange(tx_out.nValue) || !MoneyRange(nValueOut + tx_out.nValue)) throw std::runtime_error(std::string(__func__) + ": value out of range"); + nValueOut += tx_out.nValue; } + assert(MoneyRange(nValueOut)); return nValueOut; } |