diff options
author | fanquake <fanquake@gmail.com> | 2023-04-20 09:52:17 +0100 |
---|---|---|
committer | fanquake <fanquake@gmail.com> | 2023-04-20 10:04:47 +0100 |
commit | b6279243002a4bca2c87bd366dc908747aa5b513 (patch) | |
tree | d3e2ab042aeb6911c2edf319103984abc07ea627 /src/primitives/block.h | |
parent | d26a71a94ac4ae1b1a091f4412d390afba69b2f8 (diff) | |
parent | 3cc989da5c750e740705131bed05bbf93bfdf169 (diff) | |
download | bitcoin-b6279243002a4bca2c87bd366dc908747aa5b513.tar.xz |
Merge bitcoin/bitcoin#26681: contrib: Bugfix for checking bad dns seeds without casting in `makeseeds.py`
3cc989da5c750e740705131bed05bbf93bfdf169 Fix checking bad dns seeds without casting (Yusuf Sahin HAMZA)
Pull request description:
- Since seed lines comes with `str` type, comparing `good` column directly with **0** (`int` type) in the if statement was not working at all. This is fixed by casting `int` type to the values in the `good` column of seeds text file.
- Lines that starts with comment in the seeds text file are now ignored.
- If statement for checking bad seeds are moved to the top of the `parseline` function as if a seed is bad; there is no point of going forward from there.
Since this bug-fix eliminates bad seeds over **550k** in the first place, in my case; particular job for parsing all seeds speed is up by **600%** and whole script's speed is up by **%30**.
Note that **stats** in the terminal are not going to include bad seeds after this fix, which would be the same if this bug were never there before.
ACKs for top commit:
achow101:
ACK 3cc989da5c750e740705131bed05bbf93bfdf169
jonatack:
ACK 3cc989da5c750e740705131bed05bbf93bfdf169
Tree-SHA512: 13c82681de4d72de07293f0b7f09721ad8514a2ad99b0584d1c94fa5f2818821df2000944f9514d6a222a5dccc82856d16c8c05aa36d905cfa7d4610c629fd38
Diffstat (limited to 'src/primitives/block.h')
0 files changed, 0 insertions, 0 deletions