aboutsummaryrefslogtreecommitdiff
path: root/src/primitives/block.h
diff options
context:
space:
mode:
authorpracticalswift <practicalswift@users.noreply.github.com>2017-06-01 16:13:35 +0200
committerpracticalswift <practicalswift@users.noreply.github.com>2017-09-22 14:59:27 +0200
commit9ad6746ccd6dc31141fd0144686b641e31bf626b (patch)
treea5f2a33bef9eae6fde623ba8fd9233f1bb9942a4 /src/primitives/block.h
parent98212745c8acb5cc4e688bbb3979bfd46b25f98a (diff)
Use static_cast instead of C-style casts for non-fundamental types
A C-style cast is equivalent to try casting in the following order: 1. const_cast(...) 2. static_cast(...) 3. const_cast(static_cast(...)) 4. reinterpret_cast(...) 5. const_cast(reinterpret_cast(...)) By using static_cast<T>(...) explicitly we avoid the possibility of an unintentional and dangerous reinterpret_cast. Furthermore static_cast<T>(...) allows for easier grepping of casts.
Diffstat (limited to 'src/primitives/block.h')
-rw-r--r--src/primitives/block.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/primitives/block.h b/src/primitives/block.h
index 292df40896..ed97c5d4ea 100644
--- a/src/primitives/block.h
+++ b/src/primitives/block.h
@@ -86,14 +86,14 @@ public:
CBlock(const CBlockHeader &header)
{
SetNull();
- *((CBlockHeader*)this) = header;
+ *(static_cast<CBlockHeader*>(this)) = header;
}
ADD_SERIALIZE_METHODS;
template <typename Stream, typename Operation>
inline void SerializationOp(Stream& s, Operation ser_action) {
- READWRITE(*(CBlockHeader*)this);
+ READWRITE(*static_cast<CBlockHeader*>(this));
READWRITE(vtx);
}