diff options
| author | Samuel Dobson <dobsonsa68@gmail.com> | 2021-09-28 20:19:16 +1300 |
|---|---|---|
| committer | Samuel Dobson <dobsonsa68@gmail.com> | 2021-09-28 20:20:06 +1300 |
| commit | a8bbd4cc819633ec50ed0f763b6a75330ae055fb (patch) | |
| tree | 52493cf049fa1cf804e0c97e91bb0334ba41a76e /src/pow.cpp | |
| parent | 27836f296d1c5eee83282466fbabdfb097eda2ae (diff) | |
| parent | efcaefc7b5ffe0495e7c809032342ee5ca4841be (diff) | |
Merge bitcoin/bitcoin#22938: test: Add remaining scenarios of 0 waste, in wallet waste_test
efcaefc7b5ffe0495e7c809032342ee5ca4841be test: Add remaining scenarios of 0 waste (rajarshimaitra)
Pull request description:
As per the [review club](https://bitcoincore.reviews/22009) discussion on #22009 , it was observed that there were other two fee scenarios in which selection waste could be zero.
These are:
- (LTF - Fee) == Change Cost
- (LTF - Fee) == Excess
Even though these are obvious by the definition of waste metric, adding tests for them can be helpful in explaining its behavior
to new readers of the code base, along with pinning the behavior for future.
This PR adds those two cases to waste calculation unit test.
Also let me know if I am missing more scenarios.
ACKs for top commit:
jonatack:
Tested re-ACK efcaefc7b5ffe0495e7c809032342ee5ca4841be
achow101:
ACK efcaefc7b5ffe0495e7c809032342ee5ca4841be
meshcollider:
ACK efcaefc7b5ffe0495e7c809032342ee5ca4841be
Tree-SHA512: 13fe3e2c0ea7bb58d34e16c32908b84705130dec16382ff941e5e60ca5b379f9c5811b33f36c4c72d7a98cfbb6af2f196d0a69e96989afa4b9e49893eaadd7cb
Diffstat (limited to 'src/pow.cpp')
0 files changed, 0 insertions, 0 deletions