diff options
| author | MarcoFalke <falke.marco@gmail.com> | 2021-12-15 16:10:17 +0100 |
|---|---|---|
| committer | MarcoFalke <falke.marco@gmail.com> | 2021-12-15 16:10:23 +0100 |
| commit | c09b41dc665bcc7d6dcc464f1d279e8eca598c8d (patch) | |
| tree | a7478b91241915b6b5300892bbf0a7e9f8d1cbd7 /src/node | |
| parent | b8cc75435a0bcb6c62083ff134b1ba3d2ace50d1 (diff) | |
| parent | faf2614f60efe972b47b6fa00cfbc22d04ea7239 (diff) | |
| download | bitcoin-c09b41dc665bcc7d6dcc464f1d279e8eca598c8d.tar.xz | |
Merge bitcoin/bitcoin#23769: Disallow copies of CChain
faf2614f60efe972b47b6fa00cfbc22d04ea7239 style: Use 4 spaces for indendation, not 5 (MarcoFalke)
fada66fc2c716fc148104b6180da12efc5d05e41 Disallow copies of CChain (MarcoFalke)
Pull request description:
Creating a copy of the chain is not a valid use case in normal operation. Also, it massively degrades performance.
However, it seems to be a mistake that no one looks out for during review:
* https://github.com/bitcoin/bitcoin/pull/22677#discussion_r760400537
Fix this by disallowing it.
ACKs for top commit:
jamesob:
ACK faf2614f60efe972b47b6fa00cfbc22d04ea7239 ([`jamesob/ackr/23769.1.MarcoFalke.disallow_copies_of_cchai`](https://github.com/jamesob/bitcoin/tree/ackr/23769.1.MarcoFalke.disallow_copies_of_cchai))
glozow:
utACK faf2614f60efe972b47b6fa00cfbc22d04ea7239, nice.
prusnak:
utACK faf2614
Tree-SHA512: 27b908c78842e4700e118adb876c09c3d1ec04662310e983309e2cd6fa8ad38c9359ff45f36a804359b9f117e351c4739e651b3e6754c14e6c6fcd7ae5e68342
Diffstat (limited to 'src/node')
0 files changed, 0 insertions, 0 deletions