diff options
| author | Russell Yanofsky <russ@yanofsky.org> | 2021-06-14 17:06:00 -0400 |
|---|---|---|
| committer | Russell Yanofsky <russ@yanofsky.org> | 2021-09-16 14:17:01 -0400 |
| commit | 7e88f61b285e6a356ea4f6ba384858f109559985 (patch) | |
| tree | 86f1ed399bfb44c6bde11b165eaa00b0b682de4c /src/node | |
| parent | 6ef84e0503994c53f77093e7ea5951a7b0edea7a (diff) | |
| download | bitcoin-7e88f61b285e6a356ea4f6ba384858f109559985.tar.xz | |
multiprocess: Make interfaces::Chain::isTaprootActive non-const
interfaces::Chain is an abstract class, so declaring the method const
would be exposing internal implementation details of subclasses to
interface callers. And specifically this doesn't work because the
multiprocess implementation of the interfaces::Chain::isTaprootActive
method can't be const because IPC connection state and request state is
not constant during the call.
Diffstat (limited to 'src/node')
| -rw-r--r-- | src/node/interfaces.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp index c62d7e5d0b..b6778ed4cc 100644 --- a/src/node/interfaces.cpp +++ b/src/node/interfaces.cpp @@ -698,7 +698,7 @@ public: notifications.transactionAddedToMempool(entry.GetSharedTx(), 0 /* mempool_sequence */); } } - bool isTaprootActive() const override + bool isTaprootActive() override { LOCK(::cs_main); const CBlockIndex* tip = Assert(m_node.chainman)->ActiveChain().Tip(); |