diff options
| author | Antoine Riard <ariard@student.42.fr> | 2019-04-11 14:37:30 +0000 |
|---|---|---|
| committer | Antoine Riard <ariard@student.42.fr> | 2019-08-01 13:43:26 -0400 |
| commit | 8c8aa19b4b4fa56cd359092ef099bcfc7b26c334 (patch) | |
| tree | e534b3c295f52f3ab25e122256ebb753716a5850 /src/node/transaction.h | |
| parent | 7821821a23b68cc9ec49d69829ad4c939cb762e8 (diff) | |
| download | bitcoin-8c8aa19b4b4fa56cd359092ef099bcfc7b26c334.tar.xz | |
Add BroadcastTransaction utility usage in Chain interface
Access through a broadcastTransaction method.
Add a wait_callback flag to turn off race protection when wallet
already track its tx being in mempool
Standardise highfee, absurdfee variable name to max_tx_fee
We drop the P2P check in BroadcastTransaction as g_connman is only
called by RPCs and the wallet scheduler, both of which are initialized
after g_connman is assigned and stopped before g_connman is reset.
Diffstat (limited to 'src/node/transaction.h')
| -rw-r--r-- | src/node/transaction.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/node/transaction.h b/src/node/transaction.h index 51033f94e5..08ceace7f8 100644 --- a/src/node/transaction.h +++ b/src/node/transaction.h @@ -14,11 +14,13 @@ * Broadcast a transaction * * @param[in] tx the transaction to broadcast - * @param[out] &txid the txid of the transaction, if successfully broadcast * @param[out] &err_string reference to std::string to fill with error string if available - * @param[in] highfee Reject txs with fees higher than this (if 0, accept any fee) + * @param[in] max_tx_fee reject txs with fees higher than this (if 0, accept any fee) + * @param[in] relay flag if both mempool insertion and p2p relay are requested + * @param[in] wait_callback, wait until callbacks have been processed to avoid stale result due to a sequentially RPC. + * It MUST NOT be set while cs_main, cs_mempool or cs_wallet are held to avoid deadlock * return error */ -NODISCARD TransactionError BroadcastTransaction(CTransactionRef tx, uint256& txid, std::string& err_string, const CAmount& highfee); +NODISCARD TransactionError BroadcastTransaction(CTransactionRef tx, std::string& err_string, const CAmount& max_tx_fee, bool relay, bool wait_callback); #endif // BITCOIN_NODE_TRANSACTION_H |