diff options
| author | glozow <gloriajzhao@gmail.com> | 2022-07-19 09:52:55 +0100 |
|---|---|---|
| committer | glozow <gloriajzhao@gmail.com> | 2022-08-04 16:56:33 +0100 |
| commit | 1dc03dda05e9dce128e57f05bb7b1bb02b3cfb9e (patch) | |
| tree | 6fa52885a336c558b8102b40294c936449e18739 /src/node/mempool_args.cpp | |
| parent | 32024d40f03fbf47c64d814fa5f2c2a73ec14cb7 (diff) | |
[doc] remove non-signaling mentions of BIP125
Our RBF policy is different from the rules specified in BIP125. For
example, the BIP does not mention Rule 6, and our Rule 4 uses the
(configurable) incremental relay feerate (distinct from the
minimum relay feerate). Those interested in our policy should refer to
doc/policy/mempool-replacements.md instead. These rules may also
continue to diverge with package RBF and other RBF improvements. Keep
references to the BIP125 signaling wrt sequence numbers, since that is
still correct and widely used. It is helpful to refer to this as "BIP125
signaling" since it is unambiguous and succint, especially if we have
multiple ways to signal replaceability in the future.
The rule numbers in doc/policy/mempool-replacements.md correspond
largely to those of BIP 125, so we can still refer to them like "Rule 5."
Diffstat (limited to 'src/node/mempool_args.cpp')
| -rw-r--r-- | src/node/mempool_args.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node/mempool_args.cpp b/src/node/mempool_args.cpp index 60993f1d8d..cb2466804a 100644 --- a/src/node/mempool_args.cpp +++ b/src/node/mempool_args.cpp @@ -45,7 +45,7 @@ std::optional<bilingual_str> ApplyArgsManOptions(const ArgsManager& argsman, con if (auto hours = argsman.GetIntArg("-mempoolexpiry")) mempool_opts.expiry = std::chrono::hours{*hours}; - // incremental relay fee sets the minimum feerate increase necessary for BIP 125 replacement in the mempool + // incremental relay fee sets the minimum feerate increase necessary for replacement in the mempool // and the amount the mempool min fee increases above the feerate of txs evicted due to mempool limiting. if (argsman.IsArgSet("-incrementalrelayfee")) { if (std::optional<CAmount> inc_relay_fee = ParseMoney(argsman.GetArg("-incrementalrelayfee", ""))) { |