diff options
author | Samuel Dobson <dobsonsa68@gmail.com> | 2021-03-09 10:04:55 +1300 |
---|---|---|
committer | Samuel Dobson <dobsonsa68@gmail.com> | 2021-03-09 10:42:21 +1300 |
commit | a8b0892b743bf5b0bd7192f801fbc6144320052b (patch) | |
tree | 27025382e38935ebb725e3d533850d43d76a18c6 /src/netbase.h | |
parent | 2067f9e5e89113f514e5d895dcdfa8e73d63c118 (diff) | |
parent | 48a0319babb409cf486a9eb7c776810f70b06cb2 (diff) | |
download | bitcoin-a8b0892b743bf5b0bd7192f801fbc6144320052b.tar.xz |
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
48a0319babb409cf486a9eb7c776810f70b06cb2 Add a test that selects too large if BnB is used (Andrew Chow)
3e69939b78d0143d514c5d9b6c6a9844c9bb901c Fail if maximum weight is too large (Andrew Chow)
51e2cd322cfc7271af309e3a2243448a2ec0cad4 Have CalculateMaximumSignedTxSize also compute tx weight (Andrew Chow)
Pull request description:
Currently the `Transaction too large` is calculated on the transaction that is returned from `CreateTransaction`. This does not make sense for when `CreateTransaction` is being used for `fundrawtransaction` as no signing occurs so the final returned transaction is missing signatures. Thus users may successfully fund a transaction but fail to broadcast it after it has been fully signed.
So instead we should figure out whether the transaction we are funding will be too large after it is signed. We can do this by having `CalculateMaximumSignedTxSize` also return the transaction weight and then comparing that weight against the maximum weight.
ACKs for top commit:
instagibbs:
ACK https://github.com/bitcoin/bitcoin/pull/20536/commits/48a0319babb409cf486a9eb7c776810f70b06cb2
meshcollider:
utACK 48a0319babb409cf486a9eb7c776810f70b06cb2
Xekyo:
utACK with nits 48a0319babb409cf486a9eb7c776810f70b06cb2
Tree-SHA512: 1700c60b07f67e2d5c591c5ccd131ac9f1861fab3def961c3c9c4b3281ec1063fe8e4f0f7f1038cac72692340856406bcee8fb45c8104d2ad34357a0ec878ac7
Diffstat (limited to 'src/netbase.h')
0 files changed, 0 insertions, 0 deletions